From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package proposal: visual-path-abbrev.el Date: Tue, 05 Mar 2019 19:32:26 +0100 Message-ID: <875zsx18at.fsf@gnu.org> References: <87tvglpmcx.fsf@gnu.org> <83k1hhh5mb.fsf@gnu.org> <874l8k47fi.fsf@gnu.org> <83imx0f0x0.fsf@gnu.org> <87k1hg6jl3.fsf@gnu.org> <83h8ciecub.fsf@gnu.org> <8736o1iqsf.fsf@gnu.org> <83va0xcmwl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="42670"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 05 19:36:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1Evd-000AxO-MO for ged-emacs-devel@m.gmane.org; Tue, 05 Mar 2019 19:36:37 +0100 Original-Received: from localhost ([127.0.0.1]:47549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Evc-0007y3-Ec for ged-emacs-devel@m.gmane.org; Tue, 05 Mar 2019 13:36:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Ero-0005zc-FA for emacs-devel@gnu.org; Tue, 05 Mar 2019 13:32:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Erk-0000Bi-Fw for emacs-devel@gnu.org; Tue, 05 Mar 2019 13:32:38 -0500 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:45365) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1h1Erf-0005NA-3B; Tue, 05 Mar 2019 13:32:36 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 2C0FD21ACF; Tue, 5 Mar 2019 13:32:30 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 05 Mar 2019 13:32:30 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeefgdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucfkphepleefrddvfeeird duvdelrdehvdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhp rghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsug hhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmhenucevlhhushhtvghrufhiiigv pedt X-ME-Proxy: Original-Received: from thinkpad-t440p (p5dec8134.dip0.t-ipconnect.de [93.236.129.52]) by mail.messagingengine.com (Postfix) with ESMTPA id 2E13410312; Tue, 5 Mar 2019 13:32:28 -0500 (EST) Mail-Followup-To: Eli Zaretskii , emacs-devel@gnu.org In-Reply-To: <83va0xcmwl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 05 Mar 2019 18:21:30 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233853 Archived-At: Eli Zaretskii writes: >> although it's a bit sluggish when, e.g., pressing and holding C-n in >> a *grep* buffer in column 1 (which is probably the worst case). >>=20 >> I haven't yet debugged what's the slow part but I guess it is the new >> predicate `visual-file-name-abbrev--abbrev-visually-shorter-p' which >> ensures that the abbreviation is only displayed if it is visually >> shorter than the normal file name, i.e., it takes into account the >> current font and the replacement ellipsis. The standard one =E2=80=A6 is >> twice as wide as a "normal" character on a non-terminal frame. > > It is, of course, best to make functions on post-command-hook as > speedy as possible. But don't be surprised if you find out that is > not the main reason for the sluggishness: you've just disabled a very > important redisplay optimization, so you should expect some hit on the > responsiveness front. These optimizations are there for a reason, > even in these days of super-fast CPUs. Right. In my case, I just need that for the optional (but default-enabled) "display normally if point is on the overlay" feature. So the post-command-hook function could check if it is enabled and do nothing if it's not. Or it could even remove itself from p-c-h. (But then, it wouldn't start working in that buffer if the feature was later enabled (which is just adding a function to a list)). >> Other than that, do you think it's ok to add this package to ELPA? If >> so, is the (C) FSF and "This file is part of GNU Emacs" correct for an >> ELPA(-only) package? > > I'll let Stefan answer this. And I believe we have recently started > asking contributors to say explicitly in email or in the file that > they contribute the package to Emacs, for legal purposes. So please > do. Ok, great. Then let's hear what he has to say. Bye, Tassilo