From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34852: 26.1; seq-intersection ignores nil as element Date: Fri, 15 Mar 2019 15:56:19 +0000 Message-ID: <875zskrv18.fsf@tcd.ie> References: <87zhpxabn3.fsf@tcd.ie> <87va0lmwlg.fsf@web.de> <87d0mt59pz.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="201374"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Nicolas Petton , "Miguel V. S. Frasson" , 34852@debbugs.gnu.org, Stefan Monnier To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 15 17:03:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4pIb-000qFc-KM for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Mar 2019 17:03:09 +0100 Original-Received: from localhost ([127.0.0.1]:57917 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4pIa-00006k-Fp for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Mar 2019 12:03:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4pGH-0006Qk-HY for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2019 12:00:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4pCh-0007Fb-96 for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2019 11:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60085) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4pCh-0007FN-0I for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2019 11:57:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h4pCg-0006uE-Ub for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2019 11:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Mar 2019 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34852 X-GNU-PR-Package: emacs Original-Received: via spool by 34852-submit@debbugs.gnu.org id=B34852.155266539026477 (code B ref 34852); Fri, 15 Mar 2019 15:57:02 +0000 Original-Received: (at 34852) by debbugs.gnu.org; 15 Mar 2019 15:56:30 +0000 Original-Received: from localhost ([127.0.0.1]:45395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4pCA-0006sy-3M for submit@debbugs.gnu.org; Fri, 15 Mar 2019 11:56:30 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:38439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h4pC8-0006sj-2P for 34852@debbugs.gnu.org; Fri, 15 Mar 2019 11:56:28 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id a188so6514611wmf.3 for <34852@debbugs.gnu.org>; Fri, 15 Mar 2019 08:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/kcecNz6QxY7R3dbzRbhDkYdi1XSP1qQ0wdgEn9x5I8=; b=NB0aqpcTqVGG2Vf4iGWycGY/DW1kID+j3aVWDRgAZ+VLeyfk9ZufQRN3XdcxaZBgvH Ia6Jxd2uml4sJg93qSavc+SwDCPHxlAfP+K4pX5g3ccjlMD0uCRF87/zKdNLAO3p6nyN 8FGkhkNRQZ86sPjKyBGogUrl6FOO4zu6qnTVFV1CtHrh/IGtQLaTpuf8fNeMBcOJiPtb OsnpRArhcjj+RWmi5R3xVq2wEY2cpZcTpp2FuhjlRf4pLoXSQSp26e+FQMZ64Yxttx/5 2b/CCEQG99ADn7btRo2L3pRGDMoseX4LPRQtWRFwndRy5es9Ht1D4IEG3W/bLRxNa8KP /EtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/kcecNz6QxY7R3dbzRbhDkYdi1XSP1qQ0wdgEn9x5I8=; b=POliRb3qny69hFnO07+fvVnNAZzfcR2AUINyAvhEq9rcBs78M0wvJo2SH/f0++w5FL Rhok/O4LFHYSBjVHMfwr1mEkW485Cf5U+55aR/R32Tngqc6BKYCpDmj1wcE/AEkNV3o0 Nu/Cy5doDk/APRzk0a8Z8PrX4meiNxxgrmVtOI7DkOkQlZDp5t/U105+DonJzuWzb2cN ICSXs4MnJoMl1SkYSgjW7/9fh68DvmIY55HuGG4GkCay3yWLrSpJxUUtIAJd+L6UXCNz KsS0tlkXw20CICHRwSFcNTmPmTqmm9RNQHKfv1kuxxMJG2XrLO6cPx8s4yh+cmCa4EPi ZdOg== X-Gm-Message-State: APjAAAU8op2k2uGyZFyCHffQei1+30i5kOKyyolL0sN+rWndNou/bFRI BZkkR831dfcMR6/MQkBJH6bljw== X-Google-Smtp-Source: APXvYqxv0Ee/ti6Xq2XRZyJ0p5KdzgJgqGs31qQvW9KPwBIkjxzDa8rQatlsU8GywDdKH7BpY3uPCw== X-Received: by 2002:a1c:2dd1:: with SMTP id t200mr2586566wmt.148.1552665382159; Fri, 15 Mar 2019 08:56:22 -0700 (PDT) Original-Received: from localhost ([163.172.211.46]) by smtp.gmail.com with ESMTPSA id j128sm2525964wmb.43.2019.03.15.08.56.21 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 15 Mar 2019 08:56:21 -0700 (PDT) In-Reply-To: <87d0mt59pz.fsf@web.de> (Michael Heerdegen's message of "Fri, 15 Mar 2019 00:15:20 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156387 Archived-At: Michael Heerdegen writes: > "Miguel V. S. Frasson" writes: > >> In any case, of another implementation for seq-intersection or not, I >> think that the solution from Stefan should be implemented anyway >> because >> >> * it makes seq-contains provide a useful return value when ELT=nil, so >> it is a good exception; If ELT=nil, seq-contains currently returns nil >> anyway; >> >> * it makes seq-contains become a real predicate function, making it >> more useful; >> >> * since seq-contains has been used as predicate before, it is >> unpredictable which code uses it out of official repositories, so this >> fix potentially fixes other code. > > BTW, another (alternative) alternative would be to make it return > (list ELT). That would be a bit less backward-compatible, but a > bit more consistent. +1, either this or returning a boolean is fine with me. -- Basil