From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Newsgroups: gmane.emacs.devel Subject: Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere) Date: Sat, 23 Mar 2019 22:14:08 -0600 Message-ID: <875zs852pb.fsf@gmail.com> References: <87wokp4okn.fsf@gmail.com> <83ef6xpo6b.fsf@gnu.org> <0f4be9a6-6e09-f55d-9f58-2a15aef264cd@cs.ucla.edu> <837ecpplw8.fsf@gnu.org> <87imw94hi2.fsf@gmail.com> <831s2xpiba.fsf@gnu.org> <87a7hl4e01.fsf@gmail.com> <83wokpo080.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="169514"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 24 05:15:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7uXG-000hxS-BT for ged-emacs-devel@m.gmane.org; Sun, 24 Mar 2019 05:15:02 +0100 Original-Received: from localhost ([127.0.0.1]:51536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7uXF-0006rn-4z for ged-emacs-devel@m.gmane.org; Sun, 24 Mar 2019 00:15:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7uWV-0006kb-Ed for emacs-devel@gnu.org; Sun, 24 Mar 2019 00:14:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7uWU-00025V-Gm for emacs-devel@gnu.org; Sun, 24 Mar 2019 00:14:15 -0400 Original-Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:39137) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h7uWU-000259-8c; Sun, 24 Mar 2019 00:14:14 -0400 Original-Received: by mail-pg1-x532.google.com with SMTP id k3so445821pga.6; Sat, 23 Mar 2019 21:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3vQZ/K6GZsn7Lvy4JCUJuwDMnf6Ptv7bIAAp8q+s80s=; b=GoMl8cX7oXynOrjBBWr/t6mEEMMGdhJwQr5RcHb7JM/wE6FhKt0uL+1CczaMuJe0qr 28q0jFamW2rsbdCTsbMQ9x4vKgdWuBkyKXsvxIkP0CK8wRS5f3HLf2bSLYCVkzHRljTx V4bAeV6LkSzpp/rslm6XJfIDDi7NNJ+TQBpLDyGbvoQaaJJBreecBMCmNzml1gg+pAF9 beIi2Awt+qTU5rCETZ+3/Sg4W1HdQo8yS+u5LTy3WYhxYkTQM60mDS7LS4R6hyhRPT3O +bERGGupxtSGbWndQGYvGqnGwms1/n+GoFfZAMg7YpMGRRbjzp2udXDK21xv60rkKNq+ NlXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3vQZ/K6GZsn7Lvy4JCUJuwDMnf6Ptv7bIAAp8q+s80s=; b=rTELq21hi8tvMUPjU1VjAYzNme4lgnrjw1860y5MDqgeo6d2p7y33HK++XDQNHEXDt EByd/rboSRLGC5d0WoEsrqW45xjP7KR8Xv75svGJ+BHR/cUYjebIDbPyInjPyjTLIkIu Xzc9xxv2fIpWNDp8tTEv3EsZjeuLPS64rRG51kYiBeoJiOSqmuzI5AEcW9wDnSrQUxsz Yj+did/yDMGONJEuuXts37hgyTjw53FYlQm8ke+eg4rH5qdhxG96OnhUutGqsuXP49qy xzA8K74MkiMPGlZ1G9qqwkw2TCZHu7hag9QUWs/p2grzAjhMJUTcWmtyJpCJy9jrbC2L C1XQ== X-Gm-Message-State: APjAAAUbD1bZf133WY+/07AGUzK1YMXtNgqNVHPT8mmQTjk3yM9WWBxT vcnja7v/+mO/Auc/9Z7tVC7frBLE X-Google-Smtp-Source: APXvYqyFRJdqjH7VoREG3dmM2IjX0yXBEkuVZ0CjBXv3VjZ+qT1xlXNir/ZOniNnwGvzqjLlHFbJgw== X-Received: by 2002:a63:5a4b:: with SMTP id k11mr16652978pgm.119.1553400852758; Sat, 23 Mar 2019 21:14:12 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e380:2255:962f:b96:2aaf:c3d5]) by smtp.gmail.com with ESMTPSA id f9sm14671459pfd.10.2019.03.23.21.14.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Mar 2019 21:14:11 -0700 (PDT) In-Reply-To: <83wokpo080.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 Mar 2019 21:32:47 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::532 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234673 Archived-At: Eli Zaretskii writes: > I tend to prefer to do it in one go. The reason is that in the past > we've seen once or twice someone who made such initial steps towards a > goal that we considered important, but then didn't follow up with the > rest, and we were left with a slightly less readable and/or slightly > less familiar code, and no real gains. So now I'm less inclined to > support such partial steps which in themselves have little gains to > offer. I see the tendency to prefer so, but I disagree that this would make the code less readable or meaningfully less familiar. >> If you're referring to another class of x_* procedures to be renamed, >> then those can be done in a later commit. > > I think I see them all as a single class. That some of them are used > through redisplay_interface is not an important distinction, IMO. I agree that it's not the RIF aspect that's the distinguishing factor; I should have said "x_* procedures in the same class of x_* procedures as those in my patch". IMO renaming involving trivial changes (ones covered by my patch), and renaming involving branching functionality to different windowing systems are two distinct classes. I'll see about making a scratch branch for the other x_* procedures.