From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35497: [PATCH] Don't rewrite buffer contents after saving by rename Date: Tue, 30 Apr 2019 22:47:51 +0200 Message-ID: <875zqvz0co.fsf@gmx.de> References: <20190429232009.94549-1-jktomer@google.com> <87pnp4t0zp.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157323"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35497@debbugs.gnu.org To: Jonathan Tomer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 30 23:07:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLZxp-000ei6-Vp for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Apr 2019 23:06:58 +0200 Original-Received: from localhost ([127.0.0.1]:53463 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLZxp-0005dw-0T for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Apr 2019 17:06:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLZuw-0002gp-Ck for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 17:03:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLZgW-0000nL-5Y for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 16:49:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57205) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLZgV-0000mg-En for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 16:49:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hLZgT-0003pI-W2 for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 16:49:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 20:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35497 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35497-submit@debbugs.gnu.org id=B35497.155665728314620 (code B ref 35497); Tue, 30 Apr 2019 20:49:01 +0000 Original-Received: (at 35497) by debbugs.gnu.org; 30 Apr 2019 20:48:03 +0000 Original-Received: from localhost ([127.0.0.1]:42513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLZfW-0003nj-Tg for submit@debbugs.gnu.org; Tue, 30 Apr 2019 16:48:03 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:37193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLZfV-0003nE-BD for 35497@debbugs.gnu.org; Tue, 30 Apr 2019 16:48:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556657272; bh=zsO2ONEmPZqJLjNOk408BCitM0LE0ZigSBBxuiRw7yQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Edi2APgV+HFaT58dHdSJDlnjEUCX2+5fDumOnJfMsF2DfzTUMux0Jo/Hw36N0HZx/ PAot99m41nMmS7k0Nt/YnWLNnAeB0k9/hzfuO2suSDJX73K10Tb6KJSV05uKoSiHCz dz0F0+YLmfs+bJ7nMJk0FUhzX+65w2SfImCOxvKM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.52.91]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M7Gj8-1gajuA2TpO-00x1gy; Tue, 30 Apr 2019 22:47:52 +0200 In-Reply-To: (Jonathan Tomer's message of "Tue, 30 Apr 2019 12:27:55 -0700") X-Provags-ID: V03:K1:ZhMTmgda8o4Fm1F5B0+58ssBXwS73VQ72PhDCQdAM81FAdhHifW bQsl/pe9CJw3w1zoS+kk981IPO8Efvb235VomD63MVADLnqITLjH2LSlra60c0qX6RlLZJh URPliJtGCqzaVyH5JvYJAjE0rE3XX5SOoUx/23JrSKsOLe3TOSCOazAsGM/w/gLBMBrrOlX qqWb6i4xivCOFO75wTuIA== X-UI-Out-Filterresults: notjunk:1;V03:K0:e5MLxXcWJ6M=:JSftD52+Dv/pjNkBDlezh+ EL7bNZ5t/AURlgQIizHG5vJ0Qiu+BnLIARCX/k8un97VshmuwowHf5lbASYeSU/N8Vs7TLocE 4k1a4mLpBIPZLrDsWnaWR23oQg6YIqti+Ov+Q0xAUtxbHtsa4pKrz+NkmZT3z54tDvyu0sxYu 5044dd+S5bDQymISOIqk5dVqzW5h4a6+2tCp7UAMr/bHMKB8oCgT9X9cEl7uOqs7xw4S2++CA 7NWhp9Ceg5L69Fjl7mTL7a2lf1ILLfwr9q8/NWpMYW+7XO/RFT5U2bGbYI0T1dHa/AkgTKK9x MDot0fUCgTOQ6zqz3RwotrrNSgOWgJrJcjTh8LtKEtfW3Jo4V1Zq0cWHN4UfzW2n9TCOmJ477 hE8+3ZuJu2Er7icvJbMVf1o8QwYjJHGd7KAB76Izin5nburJRk6V+e/wUu0F70CF2a0/fZDxG Pzt1EINd6Vi1nIy2i4flv1KAr45CZQKE8u589MwakA3V8qhUga3DQnOUdy13iQsnfg/unkZ8H RxfuA5U55YlWmIADJXfAOw51S1Fbq8ifBxAvU/g/V+dASYkfJe8/dKw0TrQPQAAKCF0aiV6Rk hN7VskX+pDMqxZ1rqWaj2SH6hsJWv57BK3T3sowNPWMi0zH9l7pDCatt7M6SEN4UXTF4oFkb5 6AI/ebdbb1as3xwHN6vsC/JA02YR1hLSVjvI42X2p8zPQWrQsrXsoiU3bM3bJsnF8NjzE8cef 2VG5Evm/wTyuJ9HIj6cMHXvCpAmxAnI83M3o/2TT0umQY7MFquRNMLVtkOazQ2cQOKJpcxoz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158538 Archived-At: Jonathan Tomer writes: Hi Jonathan, > Thanks, I'll fix. What's the preferred mechanism for sending an > updated patch -- send an entirely new patch (relative to upstream) on > a new thread, or on this thread, or a delta to apply as an additional > commit on top of my previous patch? Please reply to these messages, keeping 35497@debbugs.gnu.org in To: or Cc:. This archives your message in the bug tracker. Usually, we appreciate a new patch relative to upstream. But in this case, not changing etc/NEWS, I believe it isn't necessary to send a new patch until there are other changes you want to show. > That said, I'm happy to add a test to tramp-tests.el as well; at the > very least, with the mock tramp method we should see that the > destination file is renamed-to rather than overwritten as well. Pls do. Btw, your new test in files-tests.el uses file notifications. Possible of course. But wouldn't it be more robust to check the inode number of the involved files, and how it changes, or not? See file-attributes how to retrieve the inode number of a file. > Thanks for the fast review! Best regards, Michael.