From: Michael Albinus <michael.albinus@gmx.de>
To: Jonathan Tomer <jktomer@google.com>
Cc: 35497@debbugs.gnu.org
Subject: bug#35497: [PATCH] Don't rewrite buffer contents after saving by rename
Date: Tue, 30 Apr 2019 22:47:51 +0200 [thread overview]
Message-ID: <875zqvz0co.fsf@gmx.de> (raw)
In-Reply-To: <CAHY_+qwCS+-Z4H8AfWScH5m+R2uRhH7QnvmdrDH9xD40F4k+Ag@mail.gmail.com> (Jonathan Tomer's message of "Tue, 30 Apr 2019 12:27:55 -0700")
Jonathan Tomer <jktomer@google.com> writes:
Hi Jonathan,
> Thanks, I'll fix. What's the preferred mechanism for sending an
> updated patch -- send an entirely new patch (relative to upstream) on
> a new thread, or on this thread, or a delta to apply as an additional
> commit on top of my previous patch?
Please reply to these messages, keeping 35497@debbugs.gnu.org in To: or Cc:.
This archives your message in the bug tracker.
Usually, we appreciate a new patch relative to upstream. But in this
case, not changing etc/NEWS, I believe it isn't necessary to send a new
patch until there are other changes you want to show.
> That said, I'm happy to add a test to tramp-tests.el as well; at the
> very least, with the mock tramp method we should see that the
> destination file is renamed-to rather than overwritten as well.
Pls do.
Btw, your new test in files-tests.el uses file notifications. Possible
of course. But wouldn't it be more robust to check the inode number of
the involved files, and how it changes, or not? See file-attributes how
to retrieve the inode number of a file.
> Thanks for the fast review!
Best regards, Michael.
next prev parent reply other threads:[~2019-04-30 20:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 23:20 bug#35497: [PATCH] Don't rewrite buffer contents after saving by rename Jonathan Tomer
2019-04-30 7:18 ` Michael Albinus
2019-04-30 19:27 ` Jonathan Tomer
2019-04-30 20:47 ` Michael Albinus [this message]
2019-04-30 21:10 ` Jonathan Tomer
2019-04-30 21:21 ` Michael Albinus
2019-04-30 22:42 ` Jonathan Tomer
2019-05-01 0:26 ` bug#35497: [PATCH v2] " Jonathan Tomer
2019-05-01 17:48 ` bug#35497: [PATCH] " Eli Zaretskii
2019-05-01 19:29 ` Jonathan Tomer
2019-05-01 19:54 ` Eli Zaretskii
2019-05-01 19:56 ` Jonathan Tomer
2019-05-01 23:02 ` bug#35497: [PATCH v3] " Jonathan Tomer
2019-05-02 11:50 ` Michael Albinus
2019-05-02 22:04 ` Jonathan Tomer
2019-05-02 22:06 ` bug#35497: [PATCH v4] " Jonathan Tomer
2019-05-03 7:52 ` Michael Albinus
2019-05-03 12:29 ` Eli Zaretskii
2019-05-06 20:45 ` Jonathan Tomer
2019-05-07 14:05 ` Michael Albinus
2019-05-07 23:46 ` Richard Stallman
2019-05-06 20:46 ` bug#35497: [PATCH v5] " Jonathan Tomer
2019-05-06 20:48 ` bug#35497: [PATCH v6] " Jonathan Tomer
2019-05-07 14:03 ` Michael Albinus
2019-05-07 14:10 ` Michael Albinus
2019-05-07 17:25 ` Jonathan Tomer
2019-05-07 17:33 ` bug#35497: [PATCH v7] " Jonathan Tomer
2019-05-08 7:48 ` Michael Albinus
2019-05-08 17:03 ` Jonathan Tomer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zqvz0co.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=35497@debbugs.gnu.org \
--cc=jktomer@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.