From: Lars Ingebrigtsen <larsi@gnus.org>
To: James Nguyen <james@jojojames.com>
Cc: 32392@debbugs.gnu.org
Subject: bug#32392: 26.1; wdired and derived dired modes
Date: Sat, 13 Jul 2019 04:58:48 +0200 [thread overview]
Message-ID: <875zo6zllj.fsf@mouse.gnus.org> (raw)
In-Reply-To: <m2eff9li7f.fsf@jojojames.com> (James Nguyen's message of "Tue, 07 Aug 2018 19:12:36 -0700")
James Nguyen <james@jojojames.com> writes:
> Digging into the function wdired-change-to-wdired-mode, that function
> throws an error if the current major mode is not 'dired-mode.
>
> (unless (eq major-mode 'dired-mode)
> (error "Not a Dired buffer"))
>
> I think we can change the check to be:
>
> (unless (derived-mode-p 'dired-mode)
> (error "Not a Dired buffer"))
Makes sense to me; I've now done this change on the Emacs trunk.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-07-13 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 2:12 bug#32392: 26.1; wdired and derived dired modes James Nguyen
2019-07-13 2:58 ` Lars Ingebrigtsen [this message]
2019-07-15 3:39 ` james
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zo6zllj.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=32392@debbugs.gnu.org \
--cc=james@jojojames.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.