From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#35421: Also bind left image rotation key Date: Wed, 17 Jul 2019 13:03:40 +0200 Message-ID: <875zo0apo3.fsf@mouse.gnus.org> References: <874l6n7zsp.5.fsf@jidanni.org> <877e8ruwvy.fsf@mouse.gnus.org> <877e8rcl79.fsf@tcd.ie> <87sgr5y263.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="25073"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35421@debbugs.gnu.org, =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 17 13:04:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hnhjI-0006NR-V7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Jul 2019 13:04:13 +0200 Original-Received: from localhost ([::1]:55934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnhjF-00048k-6s for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Jul 2019 07:04:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36846) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnhjB-00048R-Gr for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2019 07:04:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnhj9-0003jK-A6 for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2019 07:04:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42802) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hnhj9-0003j4-6I for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2019 07:04:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hnhj7-0001hB-KI for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2019 07:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jul 2019 11:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35421 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35421-submit@debbugs.gnu.org id=B35421.15633614286488 (code B ref 35421); Wed, 17 Jul 2019 11:04:01 +0000 Original-Received: (at 35421) by debbugs.gnu.org; 17 Jul 2019 11:03:48 +0000 Original-Received: from localhost ([127.0.0.1]:51623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnhit-0001gZ-L5 for submit@debbugs.gnu.org; Wed, 17 Jul 2019 07:03:47 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:46704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnhis-0001gS-AI for 35421@debbugs.gnu.org; Wed, 17 Jul 2019 07:03:47 -0400 Original-Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hnhin-0002IE-DK; Wed, 17 Jul 2019 13:03:43 +0200 In-Reply-To: <87sgr5y263.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 17 Jul 2019 00:45:08 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163236 Archived-At: "Basil L. Contovounesios" writes: > I think this is a good solution for several reasons: > > 1. It does not require a new key binding, and it does not overly > complicate the calling convention of the current key binding. > > 2. It turns image-rotate into a general image-rotating subroutine, > which users and library authors alike can reuse. > > 2.1. It does not limit rotations of imagemagick images to multiples of > 90 degrees. > > and I don't see any drawbacks, so I would like to push this to master, > subject to comments/objections. Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no