From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#36871: 26.1; I-search-toggle-csse-fold Date: Mon, 05 Aug 2019 23:39:58 +0300 Organization: LINKOV.NET Message-ID: <875znbxs7d.fsf@mail.linkov.net> References: <001201d54775$5ca376a0$15ea63e0$@mail.ru> <83lfwei9ft.fsf@gnu.org> <85o91a47l2.fsf@gmail.com> <83a7cui776.fsf@gnu.org> <004b01d547b3$0cdb14a0$26913de0$@mail.ru> <87k1bxu4vj.fsf@gmail.com> <87ftmivt4a.fsf@mail.linkov.net> <8736igslyx.fsf@mail.linkov.net> <877e7sslcq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="25990"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: a_subscriber , 36871@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 05 22:41:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hujn5-0006f5-4o for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Aug 2019 22:41:11 +0200 Original-Received: from localhost ([::1]:56882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hujn4-0006JQ-6a for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Aug 2019 16:41:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60215) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hujmz-0006J0-GG for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 16:41:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hujmy-0007oF-DJ for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 16:41:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55347) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hujmy-0007oA-3Z for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 16:41:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hujmv-0001sI-R3 for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 16:41:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Aug 2019 20:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 36871-submit@debbugs.gnu.org id=B36871.15650376317158 (code B ref 36871); Mon, 05 Aug 2019 20:41:01 +0000 Original-Received: (at 36871) by debbugs.gnu.org; 5 Aug 2019 20:40:31 +0000 Original-Received: from localhost ([127.0.0.1]:35933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hujmQ-0001rN-VJ for submit@debbugs.gnu.org; Mon, 05 Aug 2019 16:40:31 -0400 Original-Received: from fossa.birch.relay.mailchannels.net ([23.83.209.62]:22662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hujmO-0001rA-Ry; Mon, 05 Aug 2019 16:40:29 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id DE0B3340C1D; Mon, 5 Aug 2019 20:40:26 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a2.g.dreamhost.com (100-96-38-55.trex.outbound.svc.cluster.local [100.96.38.55]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4C2F6341B16; Mon, 5 Aug 2019 20:40:26 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a2.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Mon, 05 Aug 2019 20:40:26 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Turn-Hysterical: 08dc6afc0f1ebdb4_1565037626613_4111575662 X-MC-Loop-Signature: 1565037626613:4211350132 X-MC-Ingress-Time: 1565037626613 Original-Received: from pdx1-sub0-mail-a2.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTP id 3D23A837C4; Mon, 5 Aug 2019 13:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=jAFVm3 IEcK5IvbHCqRHk8gceGsM=; b=1jiiCAdQFAF/B00J6C38ttQUCKYV2QZYJV+1HM T1C/8Ju4r7BgDHnd52lEsHu9Ml+cPS9kqUAs89I7f77iF7Zx1+ZMhr38auHyHii3 gNK8qWBfyhg7YI4pGZWZqO2uFnyiRxkLPS8YqZX/SZl/bBv4cDBFt7LoCqIRNwKZ H63b4= Original-Received: from mail.jurta.org (m91-129-103-91.cust.tele2.ee [91.129.103.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTPSA id DE91B837BB; Mon, 5 Aug 2019 13:40:20 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a2 In-Reply-To: <877e7sslcq.fsf@gmail.com> (Noam Postavsky's message of "Sun, 04 Aug 2019 16:53:57 -0400") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddruddtkedgtdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgfgsehtkeertddtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrledunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrledupdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepnhhpohhsthgrvhhssehgmhgrihhlrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164652 Archived-At: tags 36871 + fixed close 36871 27.0.50 quit >>> Shouldn't toggling commands activate isearch-mode? >> >> I meant the same guarding like in isearch-yank-kill: > >> @@ -1971,6 +1971,7 @@ isearch-define-mode-toggle >> ,(format "Toggle %s searching on or off.%s" mode >> (if docstring (concat "\n" docstring) "")) >> (interactive) >> + (unless isearch-mode (isearch-mode t)) > > +1 from me, I like this better than throwing an error. So I pushed to master. Now an additional interesting question: it seems that now some global isearch-activating commands are obsolete, e.g. currently =E2=80=98M-s w=E2=80=99 runs the command isearch= -forward-word. Now it could be rebound to =E2=80=98isearch-toggle-word=E2=80=99, i.e. the current (define-key search-map "w" 'isearch-forward-word) could be replaced with (define-key search-map "w" 'isearch-toggle-word)