From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#14983: 24.3.50; url-http-end-of-document-sentinel does not work with https Date: Tue, 24 Sep 2019 09:58:42 +0200 Message-ID: <875zli2ki5.fsf@gnus.org> References: <87bo5kixuj.wl%egh@e6h.org> <20130730141910.2167122AC01@mailgate.ucop.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="15019"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 14983@debbugs.gnu.org, Andreas Schwab To: Erik Hetzner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 24 09:59:34 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCfjN-0003iS-5q for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 09:59:30 +0200 Original-Received: from localhost ([::1]:42206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCfjJ-0005Bw-K9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2019 03:59:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43577) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCfix-0005AT-Rr for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 03:59:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCfiw-0003pT-Il for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 03:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iCfiw-0003pL-FS for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 03:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iCfiw-0007qI-D7 for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2019 03:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Sep 2019 07:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14983 X-GNU-PR-Package: emacs Original-Received: via spool by 14983-submit@debbugs.gnu.org id=B14983.156931193530133 (code B ref 14983); Tue, 24 Sep 2019 07:59:02 +0000 Original-Received: (at 14983) by debbugs.gnu.org; 24 Sep 2019 07:58:55 +0000 Original-Received: from localhost ([127.0.0.1]:37565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCfip-0007px-Cq for submit@debbugs.gnu.org; Tue, 24 Sep 2019 03:58:55 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:58346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iCfim-0007pn-Sn for 14983@debbugs.gnu.org; Tue, 24 Sep 2019 03:58:53 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iCfic-0003D2-LY; Tue, 24 Sep 2019 09:58:47 +0200 In-Reply-To: <20130730141910.2167122AC01@mailgate.ucop.edu> (Erik Hetzner's message of "Tue, 30 Jul 2013 07:20:01 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167082 Archived-At: Erik Hetzner writes: > - (url-http url-current-object url-callback-function > - url-callback-arguments (current-buffer))))) > + (if (string= "https" (url-type url-current-object)) > + (url-https url-current-object url-callback-function > + url-callback-arguments (current-buffer)) > + (url-http url-current-object url-callback-function > + url-callback-arguments (current-buffer)))))) The code has changed in the meantime, so I applied the following patch instead: diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index bfc106c2a5..a6963cef70 100644 --- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -1024,7 +1024,9 @@ url-http-end-of-document-sentinel (setq url-using-proxy (url-generic-parse-url url-using-proxy))) (url-http url-current-object url-callback-function - url-callback-arguments (current-buffer))))) + url-callback-arguments (current-buffer) + (and (string= "https" (url-type url-current-object)) + 'tls))))) ((url-http-parse-headers) (url-http-activate-callback)))))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no