From: Michael Heerdegen <michael_heerdegen@web.de>
To: 37888@debbugs.gnu.org
Cc: Nicolas Petton <nicolas@petton.fr>,
Noam Postavsky <npostavs@users.sourceforge.net>
Subject: bug#37888: 27.0.50; Streams and errors in element generation
Date: Wed, 23 Oct 2019 16:58:48 +0200 [thread overview]
Message-ID: <875zkfecev.fsf@web.de> (raw)
In-Reply-To: <87eez3eduv.fsf@web.de> (Michael Heerdegen's message of "Wed, 23 Oct 2019 16:27:36 +0200")
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
Michael Heerdegen <michael_heerdegen@web.de> writes:
> (defun test-stream (n)
> (stream-cons n (if (< n 0) (error "test") (test-stream (1- n)))))
>
> (setq my-stream (test-stream 10))
>
> (condition-case nil (seq-length my-stream)
> (error (message "Hmm, didn't work so well")))
>
> Now, what happened to `my-stream' after evaluating this? If you try to
> use it, you get a quite confusing error:
>
> (seq-length my-stream)
>
> |-- stream--force: Wrong type argument: streamp, (((n . -1) t) nil ...)
Would something like this make sense (Noam)?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-WIP-stream-Fix-Bug-37888.patch --]
[-- Type: text/x-diff, Size: 999 bytes --]
From 4c778f26ff8d56d0e7018305aa3d46caa2f9fb38 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Wed, 23 Oct 2019 16:55:01 +0200
Subject: [PATCH] WIP [stream] Fix Bug#37888
---
packages/stream/stream.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/packages/stream/stream.el b/packages/stream/stream.el
index 9f73e8b861..d401fb7e3c 100644
--- a/packages/stream/stream.el
+++ b/packages/stream/stream.el
@@ -86,8 +86,8 @@ That value is the one passed to `stream-make'."
((eq (car-safe stream) stream--evald-identifier)
(cdr stream))
((eq (car-safe stream) stream--fresh-identifier)
- (setf (car stream) stream--evald-identifier)
- (setf (cdr stream) (funcall (cdr stream))))
+ (prog1 (setf (cdr stream) (funcall (cdr stream)))
+ (setf (car stream) stream--evald-identifier)))
(t (signal 'wrong-type-argument (list 'streamp stream)))))
(defmacro stream-cons (first rest)
--
2.23.0
[-- Attachment #3: Type: text/plain, Size: 11 bytes --]
Michael.
next prev parent reply other threads:[~2019-10-23 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 14:27 bug#37888: 27.0.50; Streams and errors in element generation Michael Heerdegen
2019-10-23 14:58 ` Michael Heerdegen [this message]
2019-12-13 13:10 ` Noam Postavsky
2020-01-12 7:20 ` Michael Heerdegen
2020-02-08 17:21 ` Michael Heerdegen
2019-10-24 11:38 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zkfecev.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=37888@debbugs.gnu.org \
--cc=nicolas@petton.fr \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.