From: Amin Bandali <bandali@gnu.org>
To: 38257@debbugs.gnu.org
Subject: bug#38257: Acknowledgement (27.0.50; ERC does not match or highlight nick surrounded by parens)
Date: Wed, 20 Nov 2019 01:04:33 -0500 [thread overview]
Message-ID: <875zjfrslq.fsf@gnu.org> (raw)
In-Reply-To: <87r225kwvv.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 105 bytes --]
Here’s a v2 that fixes the issue for
apostrophes as well, with a slightly tweaked
commit message.
[-- Attachment #2: 0001-Improve-ERC-s-matching-of-nicks-bug-38257.patch --]
[-- Type: text/x-diff, Size: 2239 bytes --]
From 1185e528641cbce618db93aa6604899e79300522 Mon Sep 17 00:00:00 2001
From: Amin Bandali <bandali@gnu.org>
Date: Mon, 18 Nov 2019 10:24:48 -0500
Subject: [PATCH v2] Improve ERC's matching of nicks (bug#38257)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* lisp/erc/erc-{button,match}.el (erc-{button,match}-syntax-table):
Omit (, ), and '; as they're not valid nick characters, per RFC 2812
section 2.3.1. This enables correct matching/highlighting of nicks
when they’re surrounded by parens, like (nick), and when adjacent to
an apostrophy, like nick's.
---
lisp/erc/erc-button.el | 3 ---
lisp/erc/erc-match.el | 3 ---
2 files changed, 6 deletions(-)
diff --git a/lisp/erc/erc-button.el b/lisp/erc/erc-button.el
index ec70260146..002b99520a 100644
--- a/lisp/erc/erc-button.el
+++ b/lisp/erc/erc-button.el
@@ -223,14 +223,11 @@ erc-button-keymap
(defvar erc-button-syntax-table
(let ((table (make-syntax-table)))
- (modify-syntax-entry ?\( "w" table)
- (modify-syntax-entry ?\) "w" table)
(modify-syntax-entry ?\[ "w" table)
(modify-syntax-entry ?\] "w" table)
(modify-syntax-entry ?\{ "w" table)
(modify-syntax-entry ?\} "w" table)
(modify-syntax-entry ?` "w" table)
- (modify-syntax-entry ?' "w" table)
(modify-syntax-entry ?^ "w" table)
(modify-syntax-entry ?- "w" table)
(modify-syntax-entry ?_ "w" table)
diff --git a/lisp/erc/erc-match.el b/lisp/erc/erc-match.el
index e9ed735516..336040a374 100644
--- a/lisp/erc/erc-match.el
+++ b/lisp/erc/erc-match.el
@@ -246,14 +246,11 @@ erc-match-exclude-server-buffer
;; just put it in erc.el
(defvar erc-match-syntax-table
(let ((table (make-syntax-table)))
- (modify-syntax-entry ?\( "w" table)
- (modify-syntax-entry ?\) "w" table)
(modify-syntax-entry ?\[ "w" table)
(modify-syntax-entry ?\] "w" table)
(modify-syntax-entry ?\{ "w" table)
(modify-syntax-entry ?\} "w" table)
(modify-syntax-entry ?` "w" table)
- (modify-syntax-entry ?' "w" table)
(modify-syntax-entry ?^ "w" table)
(modify-syntax-entry ?- "w" table)
(modify-syntax-entry ?_ "w" table)
--
2.23.0
next prev parent reply other threads:[~2019-11-20 6:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 15:40 bug#38257: 27.0.50; ERC does not match or highlight nick surrounded by parens Amin Bandali
[not found] ` <handler.38257.B.15740916515869.ack@debbugs.gnu.org>
2019-11-18 15:49 ` bug#38257: Acknowledgement (27.0.50; ERC does not match or highlight nick surrounded by parens) Amin Bandali
2019-11-20 6:04 ` Amin Bandali [this message]
2019-11-21 14:03 ` Lars Ingebrigtsen
2019-11-22 1:06 ` Amin Bandali
2019-11-22 12:25 ` Lars Ingebrigtsen
2019-11-22 12:31 ` Lars Ingebrigtsen
2019-11-22 13:42 ` Amin Bandali
2019-12-29 4:30 ` Amin Bandali
2019-12-29 17:30 ` Emanuel Berg via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-01-04 9:22 ` Eli Zaretskii
2020-01-09 7:14 ` Amin Bandali
2020-01-09 7:42 ` Emanuel Berg via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-01-09 18:41 ` Amin Bandali
2020-01-11 8:41 ` Eli Zaretskii
2020-01-13 7:19 ` Amin Bandali
2020-01-20 18:55 ` Stefan Kangas
2020-01-21 13:35 ` Amin Bandali
2019-11-21 20:17 ` bug#38257: Missed notif > broken buttons Corwin Brust
2020-01-03 23:39 ` bug#38257: Still working well for me (GNU 26.3 Windows 10) Corwin Brust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zjfrslq.fsf@gnu.org \
--to=bandali@gnu.org \
--cc=38257@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.