revising a [PATCH]

revising a [PATCH]

[dick.r.chiang]

What is the preferred way of revising an already submitted [PATCH]?

Re: revising a [PATCH]

[Amin Bandali]

dick.r.chiang@gmail.com writes:

> What is the preferred way of revising an
> already submitted [PATCH]?

The usual practice is to amend your commit with
the new changes, potentially rebase onto latest
commit, and send a v2.  For a recent and simple
example, see https://bugs.gnu.org/38257.

Re: revising a [PATCH]

[dick.r.chiang]

The example suggests "resubmit the patch in its entirety, as if the initially
submitted patch was never sent."

You mention "commits" and "rebasing", but I fail to see how any branch-related notions
apply here.

Re: revising a [PATCH]

[Robert Pluim]

>>>>> On Wed, 20 Nov 2019 12:58:00 -0500, dick.r.chiang@gmail.com said:

    dick> The example suggests "resubmit the patch in its entirety, as if the initially
    dick> submitted patch was never sent."

    dick> You mention "commits" and "rebasing", but I fail to see how any branch-related notions
    dick> apply here.

The master branch will have evolved since the initial patch, so it
needs to be adjusted for its current state, which is the same as
rebasing a branch with one commit.

Robert