all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 39233@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#39233: .elc file - possibly outdated backward compatibility comments
Date: Fri, 24 Jan 2020 17:08:20 +0100	[thread overview]
Message-ID: <875zh0alcb.fsf@marxist.se> (raw)
In-Reply-To: <878slwgbvd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 24 Jan 2020 15:36:22 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Reading the fix for the compilation problem, it was:
>
> -    (search-forward "\n;;; This file uses")
>
> It's quite possible that I misunderstand the patch, but doesn't this
> mean that (until a couple of days ago), Emacs assumed that that string
> exists in .elc files unconditionally.  And now it does, so if you try to
> use an Emacs from last week to load .elc files from this week, that
> week-old Emacs will break?

That code is only run during byte-compilation, not when loading the
file.  We add the lines, and then use them as an anchor to find the
location to add a version test for Emacs <23 if there are any utf-8
non-ASCII characters.

You could try on Emacs 26.1 `M-x load-file RET cperl-mode.elc RET'
using a file byte-compiled with current master to verify.

Best regards,
Stefan Kangas





  reply	other threads:[~2020-01-24 16:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22  8:44 bug#39233: .elc file - possibly outdated backward compatibility comments Stefan Kangas
2020-01-22 17:13 ` Eli Zaretskii
2020-01-23 16:26 ` Stefan Monnier
2020-01-24  9:20   ` Eli Zaretskii
2020-01-24 14:22     ` Stefan Monnier
2020-01-24 14:36       ` Lars Ingebrigtsen
2020-01-24 16:08         ` Stefan Kangas [this message]
2020-01-24 15:23       ` Eli Zaretskii
2020-01-24 17:29         ` Stefan Monnier
2020-01-24 18:45           ` Stefan Monnier
2020-01-24 19:06             ` Stefan Kangas
2020-01-24 19:14               ` Stefan Monnier
2020-01-24 19:19             ` Glenn Morris
2020-01-24 20:08             ` Eli Zaretskii
2020-09-21 12:56             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zh0alcb.fsf@marxist.se \
    --to=stefan@marxist.se \
    --cc=39233@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.