From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete Date: Sun, 15 Mar 2020 01:31:31 +0200 Organization: LINKOV.NET Message-ID: <875zf6cy3w.fsf@mail.linkov.net> References: <32b1f22f-1ac9-7fd2-0377-4c2d7ae43afd@yandex.ru> <87sgj2np8k.fsf@mail.linkov.net> <8736b06f60.fsf@mail.linkov.net> <87sgizy16y.fsf@mail.linkov.net> <1f31a329-eaee-f704-9a58-1b048a6ee636@yandex.ru> <87fteyl64x.fsf@mail.linkov.net> <47fcc86a-a884-0658-d1cb-8666704924e8@yandex.ru> <87o8tkgbe2.fsf@mail.linkov.net> <8736avy640.fsf@mail.linkov.net> <76e52ade-bb44-427a-0910-3fe3cf65bf6d@yandex.ru> <87a751uonw.fsf@mail.linkov.net> <9bab3a53-ec31-3300-132f-dc1e17ee0c53@yandex.ru> <875zfd9lzm.fsf@mail.linkov.net> <87mu8mieve.fsf@mail.linkov.net> <87k13pkxdl.fsf@mail.linkov.net> <207d4e30-aa59-b8eb-c39a-0957757f39eb@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="120511"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 34949@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 15 01:05:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jDGmJ-000VCD-Bx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Mar 2020 01:05:15 +0100 Original-Received: from localhost ([::1]:49534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDGmI-0006Jd-2r for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Mar 2020 20:05:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50315) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDGm7-0006JQ-W2 for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 20:05:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDGm6-0006fl-QH for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 20:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56344) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDGm6-0006dD-Ec for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 20:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jDGm6-0002KZ-93 for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 20:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Mar 2020 00:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 34949-submit@debbugs.gnu.org id=B34949.15842306968943 (code B ref 34949); Sun, 15 Mar 2020 00:05:02 +0000 Original-Received: (at 34949) by debbugs.gnu.org; 15 Mar 2020 00:04:56 +0000 Original-Received: from localhost ([127.0.0.1]:34084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDGm0-0002KA-3P for submit@debbugs.gnu.org; Sat, 14 Mar 2020 20:04:56 -0400 Original-Received: from bonobo.birch.relay.mailchannels.net ([23.83.209.22]:9588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jDGly-0002K2-BW for 34949@debbugs.gnu.org; Sat, 14 Mar 2020 20:04:54 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 34223501EC4; Sun, 15 Mar 2020 00:04:53 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a76.g.dreamhost.com (100-96-215-21.trex.outbound.svc.cluster.local [100.96.215.21]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7A6F2501E0D; Sun, 15 Mar 2020 00:04:52 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a76.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sun, 15 Mar 2020 00:04:52 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Madly-Dime: 069931c51f4b4f8e_1584230692756_182376148 X-MC-Loop-Signature: 1584230692756:3568654836 X-MC-Ingress-Time: 1584230692756 Original-Received: from pdx1-sub0-mail-a76.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a76.g.dreamhost.com (Postfix) with ESMTP id 29332B05B2; Sat, 14 Mar 2020 17:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=R+BZDVepYYE8gOqnMk+Zhe3bwcU=; b= QciqNKLKjYerF3msY3u8N1rnEbQgGBJA7/D/KXcLrv9yHd4EUiWiMI9zKsitAPJ6 NcpPPBVb6ymlWrSz8azYoI6EHB8x7EjYdNlEgxIj+6uWRdG7D8jOnAEB4BETVjot ED/u2/vwssgnnknChSZQCT5yprYQOyYIlDzyJC285kA= Original-Received: from mail.jurta.org (m91-129-107-65.cust.tele2.ee [91.129.107.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a76.g.dreamhost.com (Postfix) with ESMTPSA id BBD8DB05B1; Sat, 14 Mar 2020 17:04:44 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a76 In-Reply-To: <207d4e30-aa59-b8eb-c39a-0957757f39eb@yandex.ru> (Dmitry Gutov's message of "Fri, 13 Mar 2020 14:11:30 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrudeftddguddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrdeiheenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtjedrieehpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177369 Archived-At: >> Ok, here's the patch that is 10 times longer. >> It creates a new function vc-use-vc-dir-on-files >> called from vc-next-action that checks whether >> the buffer is Dired with marked directories, > > Can we create a separate command for Dired buffers instead? Good idea. > Called dired-vc-next-action. From you earlier description, I imagined that > it would simply invoke a VC-Dir in all cases, but if you need to check > whether there are any directories selected, it would call vc-dir only in > that case, and delegate to vc-next-action otherwise. > > That would be a more additive change. And the patch will be shorter. >> and for optimization returns a list of files >> to give to vc-dir via a new arg MARK-FILES. > >> Then vc-dir let-binds the global variable use-mark-files >> exactly the same way as already let-binds use-vc-backend >> since there is no other way. > > I'd rather look for another way still, without a global var (of this kind), > or passing an argument. No way to pass an argument, and the existence of the global variable use-vc-backend proves this fact. >> Then vc-dir-refresh puts all marks on files. > > Could dired-vc-next-action use vc-delayed, to then run marking code after > the vc-dir buffer refreshes? Maybe it's not working since vc-dir-refresh already doesn't use vc-run-delayed to run vc-dir-refresh-files and vc-dir-update. > Or if it's not working, or not reliable enough, we can add > a vc-dir--after-refresh-hook. Which dired-vc-next-action would add to, and > vc-dir-refresh would run (the function will remove itself from the hook > upon completion). Isn't vc-dir--after-refresh-hook a global variable too? >> Also the patch adds a new useful global keybinding 'C-x v V' >> bound to vc-next-action-on-root to open *vc-dir* buffer where >> all registered files are marked. > > Sounds more like vc-dir-root-with-registered-files-selected. I wouldn't > call it "next action" because it only provides one action. Maybe then a shorter name vc-root-dir-action?