From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 40725@debbugs.gnu.org
Subject: bug#40725: 27.0.91; Tutorial reports false positive key rebindings
Date: Wed, 22 Apr 2020 23:26:53 +0100 [thread overview]
Message-ID: <875zdrgnrm.fsf@tcd.ie> (raw)
In-Reply-To: <83pnc1ez51.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Apr 2020 16:39:38 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Cc: 40725@debbugs.gnu.org
>> Date: Mon, 20 Apr 2020 23:19:46 +0100
>>
>> The function in question, tutorial--find-changed-keys, is only ever
>> passed the defconst tutorial--default-keys as argument.
>
> Yes, and one of the aspects I thought about was whether this change
> could make use less future-proof, if more keys are added.
I don't think the proposed patch makes the code any less future-proof,
but then my crystal ball isn't the best, and tutorial.el could use some
love regardless, as this bug has shown.
>> In fact, the tutorial doesn't mention C-c at all, but apparently
>> it's included in tutorial--default-keys just because it's an
>> otherwise common prefix.
>
> AFAIU from the code, the main consideration with C-c is when the user
> turns on the CUA mode, not because it's a common prefix. So maybe we
> should narrow the test to only make sure CUA rebindings get caught?
Good point. I hadn't thought of that and I'll look into it.
>> > How do we distinguish the case where _all_ of the subcommands were
>> > rebound, for example?
>>
>> I don't think the current logic tries to handle that either, does it?
>
> Well, we are trying to improve the current logic, aren't we?
You drive a hard bargain. ;) I thought I'd suggest the current small
patch before attacking tutorial.el wholesale, but I can do both in one
go after the end of April when I'll have more free time.
While we're on the topic of improving the manual - it's on my todo to
eventually help with a Greek and possibly even Hungarian translation.
Is there anything more to it than posting a patch to
bug-gnu-emacs/emacs-devel for review, such as getting a GNU translation
team involved or anything like that?
>> > Also, don't we have some prefixes that for the purposes of the
>> > tutorial must not have _any_ of its subcommands rebound?
>>
>> Hm, I don't know. Did you have any examples in mind? The only prefixes
>> I see used in the tutorial are C-x, C-h, and Meta/ESC.
>>
>> AFAICT if a command-binding pair isn't listed in tutorial--default-keys,
>> then C-h t won't complain about it being rebound. For example, you can
>> rebind C-x k (which IS mentioned in the tutorial) and C-h t won't notice
>> at all.
>
> So maybe we should add that, to make the test more thorough?
Sure.
>> I can open another bug report for extending tutorial--default-keys to
>> detect changes to all default key bindings used in the tutorial, but for
>> now I think the proposed patch fixes the issue at hand without making
>> things worse.
>
> I just want to make sure we don't do anything that could cause subtle
> problems. Bugs while reading the tutorial are the worst kind, for
> obvious reasons.
Agreed.
--
Basil
next prev parent reply other threads:[~2020-04-22 22:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 23:31 bug#40725: 27.0.91; Tutorial reports false positive key rebindings Basil L. Contovounesios
2020-04-20 14:28 ` Eli Zaretskii
2020-04-20 22:19 ` Basil L. Contovounesios
2020-04-21 13:39 ` Eli Zaretskii
2020-04-22 22:26 ` Basil L. Contovounesios [this message]
2020-04-23 14:33 ` Eli Zaretskii
2020-04-23 21:52 ` Juri Linkov
2020-04-24 6:55 ` Eli Zaretskii
2020-04-25 3:31 ` Richard Stallman
2020-04-25 8:54 ` Eli Zaretskii
2020-04-25 20:42 ` Juri Linkov
2020-08-18 13:54 ` Lars Ingebrigtsen
2020-08-18 18:52 ` Basil L. Contovounesios
2020-08-19 10:20 ` Lars Ingebrigtsen
2021-11-12 8:28 ` Lars Ingebrigtsen
2021-11-14 23:24 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-15 5:53 ` Lars Ingebrigtsen
2020-04-24 8:46 ` Mattias Engdegård
2020-04-24 10:20 ` Eli Zaretskii
2020-04-24 10:41 ` Mattias Engdegård
2020-04-24 11:21 ` Eli Zaretskii
2020-04-24 11:35 ` Mattias Engdegård
2020-04-24 12:13 ` Eli Zaretskii
2020-04-24 12:47 ` Mattias Engdegård
2020-04-24 13:32 ` Eli Zaretskii
2020-04-24 16:01 ` Mattias Engdegård
2020-04-25 3:33 ` Richard Stallman
2020-04-25 6:20 ` Eli Zaretskii
2020-04-27 2:18 ` Richard Stallman
2020-04-27 2:37 ` Eli Zaretskii
2020-04-27 6:11 ` Andreas Schwab
2020-04-28 2:49 ` Richard Stallman
2020-04-28 7:02 ` Andreas Schwab
2020-04-29 3:25 ` Richard Stallman
2020-04-29 7:30 ` Eli Zaretskii
2020-04-30 2:32 ` Richard Stallman
2020-04-24 19:48 ` Kévin Le Gouguec
2020-04-24 19:57 ` Eli Zaretskii
2020-04-24 15:38 ` Dmitry Gutov
2020-04-24 15:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zdrgnrm.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=40725@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.