* Re: master 8ef8463: Accept lexical lambda in auto-insert-alist
[not found] ` <20200622111633.AB9FA20A26@vcs0.savannah.gnu.org>
@ 2020-06-22 14:10 ` Basil L. Contovounesios
2020-06-22 15:34 ` Mattias Engdegård
0 siblings, 1 reply; 3+ messages in thread
From: Basil L. Contovounesios @ 2020-06-22 14:10 UTC (permalink / raw)
To: Mattias Engdegård; +Cc: emacs-devel
> branch: master
> commit 8ef84632c24192a71cec89a859b064925ed5aca2
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
> Accept lexical lambda in auto-insert-alist
>
> This bug was exposed by a previous removal of quoting around lambda
> expressions in autoinsert-tests.el (1ecd350f38ee), which caused some
> of those tests to fail.
Thanks for fixing this. I wonder why I didn't get any test failures
with 'make bootstrap && make check', though? Did you run the tests as
'cd test; make autoinsert-tests' instead? Would that make a difference?
--
Basil
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: master 8ef8463: Accept lexical lambda in auto-insert-alist
2020-06-22 14:10 ` master 8ef8463: Accept lexical lambda in auto-insert-alist Basil L. Contovounesios
@ 2020-06-22 15:34 ` Mattias Engdegård
2020-06-22 16:16 ` Basil L. Contovounesios
0 siblings, 1 reply; 3+ messages in thread
From: Mattias Engdegård @ 2020-06-22 15:34 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: emacs-devel
22 juni 2020 kl. 16.10 skrev Basil L. Contovounesios <contovob@tcd.ie>:
> I wonder why I didn't get any test failures
> with 'make bootstrap && make check', though? Did you run the tests as
> 'cd test; make autoinsert-tests' instead? Would that make a difference?
I don't remember, but maybe you ran the tests byte-compiled? A compiled closure won't look like a list, and wouldn't trigger the bug.
There may be more instances of the same bug (ie, not recognising lexical closures correctly). I only had a quick look and didn't find anything outright wrong, but could very well have missed something.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 8ef8463: Accept lexical lambda in auto-insert-alist
2020-06-22 15:34 ` Mattias Engdegård
@ 2020-06-22 16:16 ` Basil L. Contovounesios
0 siblings, 0 replies; 3+ messages in thread
From: Basil L. Contovounesios @ 2020-06-22 16:16 UTC (permalink / raw)
To: Mattias Engdegård; +Cc: emacs-devel
Mattias Engdegård <mattiase@acm.org> writes:
> 22 juni 2020 kl. 16.10 skrev Basil L. Contovounesios <contovob@tcd.ie>:
>
>> I wonder why I didn't get any test failures
>> with 'make bootstrap && make check', though? Did you run the tests as
>> 'cd test; make autoinsert-tests' instead? Would that make a difference?
>
> I don't remember, but maybe you ran the tests byte-compiled? A compiled closure
> won't look like a list, and wouldn't trigger the bug.
Makes sense.
> There may be more instances of the same bug (ie, not recognising lexical
> closures correctly). I only had a quick look and didn't find anything outright
> wrong, but could very well have missed something.
Thanks. I'm sure we'll find out eventually. ;)
--
Basil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-22 16:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200622111631.31420.48804@vcs0.savannah.gnu.org>
[not found] ` <20200622111633.AB9FA20A26@vcs0.savannah.gnu.org>
2020-06-22 14:10 ` master 8ef8463: Accept lexical lambda in auto-insert-alist Basil L. Contovounesios
2020-06-22 15:34 ` Mattias Engdegård
2020-06-22 16:16 ` Basil L. Contovounesios
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.