From: Lars Ingebrigtsen <larsi@gnus.org>
To: Philipp <p.stephani2@gmail.com>
Cc: 42537@debbugs.gnu.org
Subject: bug#42537: 28.0.50; wdired-test-bug34915 test failing on macOS
Date: Tue, 04 Aug 2020 14:32:13 +0200 [thread overview]
Message-ID: <875z9ypp6a.fsf@gnus.org> (raw)
In-Reply-To: <m2365f301z.fsf@gmail.com> (Philipp's message of "Sat, 25 Jul 2020 20:46:16 +0200")
Philipp <p.stephani2@gmail.com> writes:
> :form
> (equal "bar@" "wbar@")
> :value nil :explanation
> (arrays-of-different-length 4 5 "bar@" "wbar@" first-mismatch-at 0)))
> FAILED 3/5 wdired-test-bug34915 (0.353864 sec)
>
> (Crystal ball says this might be related to macOS filename
> normalization/case-insensitivity.)
There's something very odd going on here.
If I create a file /tmp/bar and then say
(make-symbolic-link "bar" "foo")
I get, as expected
-rw-r--r-- 1 larsi wheel 0 Aug 4 14:09 bar
lrwxr-xr-x 1 larsi wheel 3 Aug 4 14:09 foo -> bar
However, if I do something similar in the test director, dired insists
on adding a "@" to the end of the file name, which messes up everything:
/var/folders/l6/0kf2px5j7tz_wbp9lf_hgfwm0000gn/T/test-dir-iRvcaN:
-rw-r--r-- 1 larsi staff 1 Aug 4 14:12 zot
lrwxr-xr-x 1 larsi staff 3 Aug 4 14:14 zotlink@ -> zot
Uhm... Oh, that's the entire point of the test. :-) "ls -F" adds the
"@".
So the error is a real bug, because
(dired-get-filename 'no-dir t)
=> "zotlink@"
And that's because dired-ls-F-marks-symlinks is nil...
;; 1. For dired to work on a host which marks symlinks with a trailing @ in
;; an ls -alF listing, you need to (setq dired-ls-F-marks-symlinks t).
;; Most UNIX systems do not do this, but ULTRIX does.
And Macos is another:
larsi@space /tmp % ls -alF /tmp/
total 0
drwxrwxrwt 8 root wheel 256 Aug 4 14:12 ./
drwxr-xr-x 6 root wheel 192 Aug 2 18:53 ../
-rw-r--r-- 1 larsi wheel 0 Aug 4 14:09 bar
lrwxr-xr-x 1 larsi wheel 3 Aug 4 14:09 foo@ -> bar
lrwxr-xr-x 1 larsi wheel 3 Aug 4 14:10 foo3@ -> bar
lrwxr-xr-x 1 larsi wheel 3 Aug 4 14:12 foo4@ -> bar
OK, I've now adjusted the test and fixed the doc string to
dired-ls-F-marks-symlinks in Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-04 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 18:46 bug#42537: 28.0.50; wdired-test-bug34915 test failing on macOS Philipp
2020-08-04 12:32 ` Lars Ingebrigtsen [this message]
2020-08-04 13:23 ` Robert Pluim
2020-08-04 13:33 ` Lars Ingebrigtsen
2020-08-04 13:44 ` Lars Ingebrigtsen
2020-08-04 13:57 ` Lars Ingebrigtsen
2020-08-04 16:27 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z9ypp6a.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=42537@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.