From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive Date: Tue, 01 Sep 2020 17:06:50 +0200 Message-ID: <875z8xcz91.fsf@gnus.org> References: <87pn7hawal.fsf@gmx.net> <878se4dy9u.fsf@gnus.org> <87lfi1emz4.fsf@gmx.net> <873648xmvf.fsf@gnus.org> <87sgc83z3k.fsf@gmx.net> <87mu2evp51.fsf@gnus.org> <87tuwm95za.fsf@gmx.net> <87a6yctfmi.fsf@gnus.org> <87mu2btbd9.fsf@gmx.net> <87k0xdd11a.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36361"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43003-done@debbugs.gnu.org, Stephen Berman To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 01 17:13:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD7yJ-0009JL-4l for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Sep 2020 17:13:19 +0200 Original-Received: from localhost ([::1]:51882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD7yI-0008VJ-25 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Sep 2020 11:13:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD7tC-0000ti-TY for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 11:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45245) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kD7tC-0004HL-HX for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 11:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kD7tC-0006PQ-DB for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 11:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Sep 2020 15:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43003 X-GNU-PR-Package: emacs Original-Received: via spool by 43003-done@debbugs.gnu.org id=D43003.159897282424564 (code D ref 43003); Tue, 01 Sep 2020 15:08:02 +0000 Original-Received: (at 43003-done) by debbugs.gnu.org; 1 Sep 2020 15:07:04 +0000 Original-Received: from localhost ([127.0.0.1]:56791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7sF-0006O6-UF for submit@debbugs.gnu.org; Tue, 01 Sep 2020 11:07:04 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:40852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kD7sD-0006NV-L1 for 43003-done@debbugs.gnu.org; Tue, 01 Sep 2020 11:07:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qt8KGDceM2IKJywVr8C8B65/Oeh0ynxtakQNSQ++6yY=; b=h0+TpeY0Od8z+JUeTsbgFStDlb lPggRAaez1Sk3Mbs3VptcO2l5KoL8cEj/Ci3plWUAG939qTaS2uyhYk9lPGKtbRLchZJ1TD6LZcwP Yi0ZbOw1s5GQhGS691gywHD1LycW2OcFzqFuNdgiRzvgdEvlOY5TRnnfyc6vGl2wPimQ=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD7s3-0002ku-Nj; Tue, 01 Sep 2020 17:06:55 +0200 X-Now-Playing: DACM's =?UTF-8?Q?=5FSt=C3=A9r=C3=A9otypie=5F:?= "Latex" In-Reply-To: (Robert Pluim's message of "Tue, 01 Sep 2020 17:03:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186854 Archived-At: Robert Pluim writes: > >> - (string-match comint-password-prompt-regexp string)) > >> + (string-match comint-password-prompt-regexp > >> + (replace-regexp-in-string "\r" "" string))) > > Lars> Yes, that makes sense to me. > > Done in 2e3ec40293 One thought -- just as a precaution, would it make sense to do this replacement only if the \r is at the start of a line, and it's not followed by a \n? I'm just slightly worried that there may be repercussions on systems that use \r\n as end-of-line markers... it probably makes no difference here, but... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no