From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34027: 27.0.50; disable-theme resets variables to their initial values Date: Sat, 05 Sep 2020 13:55:03 +0200 Message-ID: <875z8s8mlk.fsf@gnus.org> References: <87y37sd7iq.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20765"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Albinus , 34027@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 13:56:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEWno-0005Fy-T8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 13:56:16 +0200 Original-Received: from localhost ([::1]:55488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEWnn-0003JH-Sg for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 07:56:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEWna-0003It-DS for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 07:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEWna-0003sK-4u for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 07:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEWna-0006Zj-3C for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 07:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 11:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34027 X-GNU-PR-Package: emacs Original-Received: via spool by 34027-submit@debbugs.gnu.org id=B34027.159930691725205 (code B ref 34027); Sat, 05 Sep 2020 11:56:02 +0000 Original-Received: (at 34027) by debbugs.gnu.org; 5 Sep 2020 11:55:17 +0000 Original-Received: from localhost ([127.0.0.1]:41653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEWmr-0006YS-IS for submit@debbugs.gnu.org; Sat, 05 Sep 2020 07:55:17 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:60314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEWmp-0006YA-Rd for 34027@debbugs.gnu.org; Sat, 05 Sep 2020 07:55:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jtjyD+4FYABoxM84m4B+w9rgop3fTjU+kkij3IUTOKU=; b=l77Rfd4Ikk6a+RD26OYPDAshuV n2PS/SV7w5HzQ8ZVIggK0hjfMC9cFZp25IqAZSR7y5vzXfACclL4/dOiWfZJ4sDfufp7EzC+4J8Fl tA1CTi8WsQZDSuMSDuW+PPz8yEEcQf6IwdB+RhV8e/JWd2ieMIXG8AeKA3+de69aQOnk=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEWme-0003Hf-40; Sat, 05 Sep 2020 13:55:09 +0200 X-Now-Playing: Magnum 38's _A Tribute to Grace Jones_: "Sequel 1" In-Reply-To: (Mauro Aranda's message of "Fri, 4 Sep 2020 12:06:27 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187208 Archived-At: Mauro Aranda writes: > That is controlled by the variable custom--inhibit-theme-enable, and > we should bind it to nil in enable-theme, because we are definitely > enabling it. Once we do that, it is just a matter of using > custom-push-theme to handle the case like it's supposed to. > > My patch does that, and introduces an extra check in custom-push-theme, > because while testing I found another instance of Bug#28904. The rest > this patch does is changing the test because of the comments I made in > another post to this bug, and we now can expect the test to pass. Thanks, looks good to me (although I'm not all that familiar with the custom/theme integration), so I've applied your patch to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no