From: Lars Ingebrigtsen <larsi@gnus.org>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: Michael Albinus <michael.albinus@gmx.de>, 34027@debbugs.gnu.org
Subject: bug#34027: 27.0.50; disable-theme resets variables to their initial values
Date: Sat, 05 Sep 2020 13:55:03 +0200 [thread overview]
Message-ID: <875z8s8mlk.fsf@gnus.org> (raw)
In-Reply-To: <CABczVwe6YWtoD1hW-SH5h6oMawvyzT8Sxbov4B-n4b8TMyAOVg@mail.gmail.com> (Mauro Aranda's message of "Fri, 4 Sep 2020 12:06:27 -0300")
Mauro Aranda <maurooaranda@gmail.com> writes:
> That is controlled by the variable custom--inhibit-theme-enable, and
> we should bind it to nil in enable-theme, because we are definitely
> enabling it. Once we do that, it is just a matter of using
> custom-push-theme to handle the case like it's supposed to.
>
> My patch does that, and introduces an extra check in custom-push-theme,
> because while testing I found another instance of Bug#28904. The rest
> this patch does is changing the test because of the comments I made in
> another post to this bug, and we now can expect the test to pass.
Thanks, looks good to me (although I'm not all that familiar with the
custom/theme integration), so I've applied your patch to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-09-05 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 12:25 bug#34027: 27.0.50; disable-theme resets variables to their initial values Michael Albinus
2019-01-10 16:34 ` Glenn Morris
2019-01-10 18:43 ` Michael Albinus
2020-01-03 15:25 ` Mauro Aranda
2020-09-04 15:06 ` Mauro Aranda
2020-09-05 11:55 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z8s8mlk.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=34027@debbugs.gnu.org \
--cc=maurooaranda@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.