From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master d41489a: Debbugs code cleanup Date: Mon, 07 Sep 2020 23:13:13 +0200 Message-ID: <875z8p8f4m.fsf@gnus.org> References: <20200823171107.16195.61191@vcs0.savannah.gnu.org> <20200823171108.EE3D220A10@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22453"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Albinus To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 07 23:13:57 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFOSa-0005ej-KP for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Sep 2020 23:13:56 +0200 Original-Received: from localhost ([::1]:47038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFOSZ-00024w-MT for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Sep 2020 17:13:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFOS1-0001Zj-JM for emacs-devel@gnu.org; Mon, 07 Sep 2020 17:13:21 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:51572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFORz-0000De-SJ for emacs-devel@gnu.org; Mon, 07 Sep 2020 17:13:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xcfcT+Kjt7KaKGi/tdpBHYj55vyeH+fHJvRTKm3xuiI=; b=X1STwC1imqcChSTovMg7KEu5ok EYr8T3umWFC3/+aXyUbOUwRIeh8IjHQbc3BJ8FGlfeMFQRvZIoPdCRUGI2pxcZpjklMVYr9HmW658 2fQgdJRMf8MyQ1ow2+NwvlyMiImphU4xxakMEbjXFjnubseSwY0GQeKXR6YjU5bIc5+M=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFORu-0003wc-UK; Mon, 07 Sep 2020 23:13:17 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUyNmZcQY+Ng7L/ //89f+0oAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QJBxULL4MOLPUAAAF0SURBVCjPTZCxTsMwEIb/ ItKhU5FIJbozpE+RIrK3ks9SPDHUkeqnKBsjA46UTkHCCN9TcnZaxEmJ78t/d78vwFzhFpjxFwo5 CEfMtxwAvM0PJaP65FgDUTNzvTk4FuAUqA6aMANVzvh681LsUAJLmi3GapcnpVh/PZxQlPcZNswR yxITGBm4mwSsz8ynu6kFlXidCj9BXAtA5XzGPsEUN+fwD8yZ9fsF5ubHJ7hJsHCD1yOwyjZkMjzK LLvwGeqDgGOvfTHCfUiVYdK+HN1Q5DsTeeK+kV3HTSSJ0JDCa+SU0zY2Ci+yWAITToSnyHEvwPyq 4ELPpUC7989Ik0ip3If02pMq3RW2TdLsBYj+l9VUkioE4pH+FBda2ruVzBSFg3w7UkNkYaYKJcYB MVjKEmmH3mdFLntkTFU6kHcCVotm5TfYHm12sa08FjQYScTL2wDqjXHuOw7sWjElcrZrh74jaD20 ne1E6TS0bJqaLF9WuMYvm227JUHg7vQAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDktMDdUMjE6 MTE6NDcrMDA6MDB8f5r4AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA5LTA3VDIxOjExOjQ3KzAw OjAwDSIiRAAAAABJRU5ErkJggg== X-Now-Playing: Meg Hentges's _Afterlaugh_: "When I Peaked" In-Reply-To: <20200823171108.EE3D220A10@vcs0.savannah.gnu.org> (Michael Albinus's message of "Sun, 23 Aug 2020 13:11:08 -0400 (EDT)") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254680 Archived-At: Michael.Albinus@gmx.de (Michael Albinus) writes: > If a report is tagged locally, it is presumed to be of little > interest to you." > (interactive) > - (save-excursion > - (beginning-of-line) > - (let ((inhibit-read-only t) > - (id (debbugs-gnu-current-id))) > - (if (memq id debbugs-gnu-local-tags) > - (progn > - (setq debbugs-gnu-local-tags (delq id debbugs-gnu-local-tags)) > - (put-text-property (point) (+ (point) 5) 'face 'default)) > - (add-to-list 'debbugs-gnu-local-tags id) > - (put-text-property > - (+ (point) (- 5 (length (number-to-string id)))) (+ (point) 5) > - 'face 'debbugs-gnu-tagged)) > - (debbugs-gnu--update-tag-face id))) > + (let ((id (debbugs-gnu-current-id))) > + (if (memq id debbugs-gnu-local-tags) > + (setq debbugs-gnu-local-tags (delq id debbugs-gnu-local-tags)) > + (add-to-list 'debbugs-gnu-local-tags id)) > + (debbugs-gnu--update-tag-mark-face id) > + ;; FIXME: Use `debbugs-gnu-print-entry'? > + (tabulated-list-init-header) > + (tabulated-list-print) > + (when id > + (debbugs-gnu-goto id))) > (debbugs-gnu-dump-persistency-file)) Michael, `t' after this change rearranges the buffer and makes the command rather useless -- if you've sorted by tagging, and then untag something, it's then resorted according to the new tag state, and you lose your position in the list of bugs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no