Re: [elpa] master d41489a: Debbugs code cleanup

Re: [elpa] master d41489a: Debbugs code cleanup

[Lars Ingebrigtsen]

Michael.Albinus@gmx.de (Michael Albinus) writes:

>  If a report is tagged locally, it is presumed to be of little
>  interest to you."
>    (interactive)
> -  (save-excursion
> -    (beginning-of-line)
> -    (let ((inhibit-read-only t)
> -	  (id (debbugs-gnu-current-id)))
> -      (if (memq id debbugs-gnu-local-tags)
> -	  (progn
> -	    (setq debbugs-gnu-local-tags (delq id debbugs-gnu-local-tags))
> -	    (put-text-property (point) (+ (point) 5) 'face 'default))
> -	(add-to-list 'debbugs-gnu-local-tags id)
> -	(put-text-property
> -	 (+ (point) (- 5 (length (number-to-string id)))) (+ (point) 5)
> -	 'face 'debbugs-gnu-tagged))
> -      (debbugs-gnu--update-tag-face id)))
> +  (let ((id (debbugs-gnu-current-id)))
> +    (if (memq id debbugs-gnu-local-tags)
> +	(setq debbugs-gnu-local-tags (delq id debbugs-gnu-local-tags))
> +      (add-to-list 'debbugs-gnu-local-tags id))
> +    (debbugs-gnu--update-tag-mark-face id)
> +    ;; FIXME: Use `debbugs-gnu-print-entry'?
> +    (tabulated-list-init-header)
> +    (tabulated-list-print)
> +    (when id
> +      (debbugs-gnu-goto id)))
>    (debbugs-gnu-dump-persistency-file))

Michael, `t' after this change rearranges the buffer and makes the
command rather useless -- if you've sorted by tagging, and then untag
something, it's then resorted according to the new tag state, and you
lose your position in the list of bugs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [elpa] master d41489a: Debbugs code cleanup

[Michael Albinus]

Lars Ingebrigtsen <larsi@gnus.org> writes:

Hi Lars,

>> +  (let ((id (debbugs-gnu-current-id)))
>> +    (if (memq id debbugs-gnu-local-tags)
>> +	(setq debbugs-gnu-local-tags (delq id debbugs-gnu-local-tags))
>> +      (add-to-list 'debbugs-gnu-local-tags id))
>> +    (debbugs-gnu--update-tag-mark-face id)
>> +    ;; FIXME: Use `debbugs-gnu-print-entry'?
>> +    (tabulated-list-init-header)
>> +    (tabulated-list-print)
>> +    (when id
>> +      (debbugs-gnu-goto id)))
>>    (debbugs-gnu-dump-persistency-file))
>
> Michael, `t' after this change rearranges the buffer and makes the
> command rather useless -- if you've sorted by tagging, and then untag
> something, it's then resorted according to the new tag state, and you
> lose your position in the list of bugs.

I see. I'll try to implement the FIXME instead.

;; FIXME: Use `debbugs-gnu-print-entry'?

Best regards, Michael.

Re: [elpa] master d41489a: Debbugs code cleanup

[Michael Albinus]

Michael Albinus <michael.albinus@gmx.de> writes:

Hi Lars,

>> Michael, `t' after this change rearranges the buffer and makes the
>> command rather useless -- if you've sorted by tagging, and then untag
>> something, it's then resorted according to the new tag state, and you
>> lose your position in the list of bugs.
>
> I see. I'll try to implement the FIXME instead.
>
> ;; FIXME: Use `debbugs-gnu-print-entry'?

I've pushed a fix to ELPA, which should fix it. Does it for you?

Best regards, Michael.

Re: [elpa] master d41489a: Debbugs code cleanup

[Lars Ingebrigtsen]

Michael Albinus <michael.albinus@gmx.de> writes:

> I've pushed a fix to ELPA, which should fix it. Does it for you?

Yes, thanks -- everything looks good to me now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no