From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#21380: 25.0.50; GTK-induced segfault when scheduling timer from window-configuration-change-hook Date: Mon, 07 Sep 2020 19:07:18 +0200 Message-ID: <875z8p5xdl.fsf@gnus.org> References: <83mvx8252m.fsf@gnu.org> <83k2sc20k6.fsf@gnu.org> <83h9ng1ryx.fsf@gnu.org> <83a8t71qct.fsf@gnu.org> <837foaceid.fsf@gnu.org> <83vbbuawgy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22315"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 21380@debbugs.gnu.org, Stefan Monnier To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 07 19:08:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFKcj-0005hf-Pe for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 19:08:09 +0200 Original-Received: from localhost ([::1]:47428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFKci-00085Z-G6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 13:08:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFKcc-00085B-Ps for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 13:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFKcc-0003GV-Go for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 13:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFKcc-0006BC-9s for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 13:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Sep 2020 17:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21380 X-GNU-PR-Package: emacs Original-Received: via spool by 21380-submit@debbugs.gnu.org id=B21380.159949845223717 (code B ref 21380); Mon, 07 Sep 2020 17:08:02 +0000 Original-Received: (at 21380) by debbugs.gnu.org; 7 Sep 2020 17:07:32 +0000 Original-Received: from localhost ([127.0.0.1]:50650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFKc8-0006AT-73 for submit@debbugs.gnu.org; Mon, 07 Sep 2020 13:07:32 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:59642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFKc6-0006AG-4t for 21380@debbugs.gnu.org; Mon, 07 Sep 2020 13:07:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TOY41p4VNock1l2eHD9L1NWRakCvTU0t8ghCENV8lPo=; b=DFsR6LK9Aw9PnDRIe17ouHiENR JaJ4hPE289a322WXIZkOIcqW190AIEuueH5KKDmDgkiJS66743h1M/w5J6WGiczKRNUbrdTrYja8E OuVnOayFQtjHanc58B5tID9L9xXDLKyS8X7NNy/2ufe007wiRFdjqp9CIdWabGqoMEEo=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFKbv-0001Zv-Nk; Mon, 07 Sep 2020 19:07:22 +0200 X-Now-Playing: Coil's _A Prison of Measured Time_: "Wir Clk Wir (A Deeply Disturbed Passing Mix)" In-Reply-To: (Pip Cet's message of "Tue, 1 Sep 2015 20:48:18 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187458 Archived-At: Pip Cet writes: > * keyboard.c (timer_check): Call `block_input' and turn off > atimers around the creation of the temporary timer list copy. > > * fns.c (concat): Don't assume argument size remains unchanged > after call to `Fmake_list'. Return incorrect results (but don't > segfault) in that case. Skimming this thread, it seemed like the first part fixes a segfault (and the second part was probably not needed), but not even the first part was applied? (I just had a peek at timer_check to check.) The discussion instead turned to the idea of avoiding the timers = Fcopy_sequence (Vtimer_list); completely, and just working directly off of Vtimer_list. Which seems like a good idea, but there may be unknown unknowns in that scenario? In any case, the timer_check change seems safe, and fixes a (somewhat obscure) segfault, so does anybody object to putting that in? (We can also add a FIXME to the code here mentioning the possibility of not copying the list.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no