From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43441: 27.1; [PATCH] Fix incorrectly base64-padded faces in gnus-convert-face-to-png Date: Thu, 17 Sep 2020 17:31:13 +0200 Message-ID: <875z8cpghq.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29329"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43441@debbugs.gnu.org To: Alex Bochannek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 17:36:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIvxE-0007X1-E8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 17:36:12 +0200 Original-Received: from localhost ([::1]:37694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIvxD-0000Cy-DV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 11:36:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIvtH-0005Sj-Bz for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 11:32:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIvtC-0007Bv-61 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 11:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIvtC-00084A-38 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 11:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 15:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43441 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43441-submit@debbugs.gnu.org id=B43441.160035668829380 (code B ref 43441); Thu, 17 Sep 2020 15:32:02 +0000 Original-Received: (at 43441) by debbugs.gnu.org; 17 Sep 2020 15:31:28 +0000 Original-Received: from localhost ([127.0.0.1]:38679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIvsd-0007dC-90 for submit@debbugs.gnu.org; Thu, 17 Sep 2020 11:31:27 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIvsa-0007Ve-EL for 43441@debbugs.gnu.org; Thu, 17 Sep 2020 11:31:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qZ3rwku652w7fuWX7vuG3ktu8bBIfd12O34cGEXijes=; b=DbAy5bvrrcbeOk1hQqBx/bbogr yIlgfYLJQCGxCEr0tDK1+CSeRC8Fg539WrD/XaCbMvYWJkHUSkmUYrspEFzcA+sXj4Fym1S2l3/wS 6qhaY+Cbj0ZYmFuAhdtOPGTgNVpR0UDe1JSl7xqQkl7IyaSzzKhMuWyUIh22J226BPV8=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIvsR-0001wR-0W; Thu, 17 Sep 2020 17:31:17 +0200 X-Now-Playing: PJ Harvey's _Dry Demos_: "Plants And Rags" In-Reply-To: (Alex Bochannek's message of "Tue, 15 Sep 2020 23:06:53 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188213 Archived-At: Alex Bochannek writes: > I don't suspect this problem is widespread in other uses of the base64 > decoder, so it seems appropriate to me to just patch > gnus-convert-face-to-png to generate the right amount of padding. Hm... I think it would be nice to have a utility function to fix up base64 padding, and then gnus-convert-face-to-png could just use that? It should work for both base64 that has newlines inserted and not. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no