From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49081: 28.0.50; [PATCH] Feature suggestion, Gnus summary mode sorting for extra headers Date: Sat, 19 Jun 2021 15:14:15 +0200 Message-ID: <875yya0zfc.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35732"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49081@debbugs.gnu.org To: Alex Bochannek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 19 15:15:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luaoX-00098M-NW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Jun 2021 15:15:09 +0200 Original-Received: from localhost ([::1]:59634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luaoW-0001DH-Ot for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Jun 2021 09:15:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luaoQ-0001Cb-3D for bug-gnu-emacs@gnu.org; Sat, 19 Jun 2021 09:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47227) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luaoP-0004Hc-RC for bug-gnu-emacs@gnu.org; Sat, 19 Jun 2021 09:15:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luaoP-000256-NS for bug-gnu-emacs@gnu.org; Sat, 19 Jun 2021 09:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jun 2021 13:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49081 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49081-submit@debbugs.gnu.org id=B49081.16241084677932 (code B ref 49081); Sat, 19 Jun 2021 13:15:01 +0000 Original-Received: (at 49081) by debbugs.gnu.org; 19 Jun 2021 13:14:27 +0000 Original-Received: from localhost ([127.0.0.1]:58770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luanq-00023s-O0 for submit@debbugs.gnu.org; Sat, 19 Jun 2021 09:14:26 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:51408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luano-00023a-8a for 49081@debbugs.gnu.org; Sat, 19 Jun 2021 09:14:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ziMnWqwmf37wQcBLPhb3ucm+OtkmCU6QCISQNLE3WZw=; b=GMpxQ67P4K8iEzLPCZJSWYgxCK lE87GnB/IDxxy4T1U171m4AAn3O8R7vp8VUp8t2oipGbntIKtkqgfO3UI5ZOLeiHZMsv9txb2YXlq PwZIZDVD9s/OmM1xl/NmiSeh35meS2EUlsdEs2WlQA8HacXPmCdqcHJIJEX94teMYXck=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luang-0002jo-7a; Sat, 19 Jun 2021 15:14:18 +0200 X-Now-Playing: Oh Sees's _Face Stabber_: "=?UTF-8?Q?Ghol=C3=BC?=" In-Reply-To: (Alex Bochannek's message of "Thu, 17 Jun 2021 16:53:11 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208730 Archived-At: Alex Bochannek writes: > Since I was able to get the Newsgroups extra header working for > `nnvirtual' groups, I would like to not only limit, but also sort by the > extra headers. Looks good; applied with one minor tweak: > +(defun gnus-article-sort-by-newsgroups (h1 h2) > + "Sort articles by newsgroups." > + (gnus-string< > + (let ((extract (funcall > + gnus-extract-address-components > + (or (cdr (assq 'Newsgroups (mail-header-extra h1))) "")))) > + (or (car extract) (cadr extract))) > + (let ((extract (funcall > + gnus-extract-address-components > + (or (cdr (assq 'Newsgroups (mail-header-extra h2))) "")))) > + (or (car extract) (cadr extract))))) I rewrote that to: (defun gnus-article-sort-by-newsgroups (h1 h2) "Sort articles by newsgroups." (let ((ex (lambda (h) (let ((extract (funcall gnus-extract-address-components (or (cdr (assq 'Newsgroups (mail-header-extra h))) "")))) (or (car extract) (cadr extract)))))) (gnus-string< (funcall ex h1) (funcall ex h2)))) To avoid the duplication -- let me know if I messed up that bit. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no