From: No Wayman <iarchivedmywholelife@gmail.com>
To: 49739@debbugs.gnu.org
Subject: bug#49739: 28.0.50; byte-compiled pcase pattern match failure
Date: Sun, 25 Jul 2021 23:33:39 -0400 [thread overview]
Message-ID: <875ywxeoit.fsf@gmail.com> (raw)
Recently a user reported a bug on Org-mode's mailing list in which
an org-capture template was failing to fill properly:
https://orgmode.org/list/87fsw3zyjl.fsf@ucl.ac.uk/T/#t
I was able to reproduce the issue with emacs -Q and the following
recipe:
Evaluate the following in *scratch*:
(progn
(require 'org-capture)
(org-capture-fill-template "%^t"))
This should prompt the user for a time, instead we hit the `_`
case in one of the pcase calls in `org-capture-fill-template'
despite the valid template string. This results in the error:
"unrecognized template placeholder: %^t"
I've observed that this only occurs when
`org-capture-fill-template' has been byte-compiled.
Re-evaluating the defun results in the expected behavior. And
byte-compiling the function puts us back in the erroneous state:
(progn
(byte-compile #'org-capture-fill-template)
(org-capture-fill-template "%^t")) ; unrecognized template
placeholder...
I didn't do a proper git-bisect, but the everything works as
expected when building from the parent
(3af2cee64b86e4ce59adb8e8720d92db35039cbc) of the following
commit:
commit 937b6c18bd6c4806eb1e4c8764db56b314c09056
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Fri Mar 19 17:42:22 2021 -0400
* lisp/emacs-lisp/pcase.el (pcase-compile-patterns): New
function (bug#47261)
Extracted from `pcase--expand`.
(pcase--expand): Use it.
I tried to do some more debugging, but I'm not familiar with how
to debug a problem which only crops up in byte-compiled elisp.
Happy to provide any other information if necessary.
~ Nick
next reply other threads:[~2021-07-26 3:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 3:33 No Wayman [this message]
2021-07-26 22:26 ` bug#49739: 28.0.50; byte-compiled pcase pattern match failure Michael Heerdegen
2021-07-27 17:10 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ywxeoit.fsf@gmail.com \
--to=iarchivedmywholelife@gmail.com \
--cc=49739@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.