From: "J.P." <jp@neverwas.me>
To: 52010@debbugs.gnu.org
Cc: emacs-erc@gnu.org
Subject: bug#52010: 28.0.60; ERC now ignores dialed server names in autojoin
Date: Sun, 21 Nov 2021 17:43:23 -0800 [thread overview]
Message-ID: <875ysl3qys.fsf__14463.3510777325$1637545460$gmane$org@neverwas.me> (raw)
In-Reply-To: <87ilwmbbz7.fsf@neverwas.me> (J. P.'s message of "Sat, 20 Nov 2021 16:15:24 -0800")
Actually, please ignore everything stated previously (and the patch as
well).
The 2017 change [1] was *not* the source of the problem as wrongly
implied in my previous email (although it did get the ball rolling by
changing from announced to dialed names for auth-source queries). The
real culprit is actually something way more recent [2]:
diff --git a/lisp/erc/erc-join.el b/lisp/erc/erc-join.el
index e4faf6bd79..79c111082f 100644
--- a/lisp/erc/erc-join.el
+++ b/lisp/erc/erc-join.el
@@ -153,18 +153,20 @@ erc-autojoin-channels
'erc-autojoin-channels-delayed
server nick (current-buffer))))
;; `erc-autojoin-timing' is `connect':
- (dolist (l erc-autojoin-channels-alist)
- (when (string-match (car l) server)
- (let ((server (or erc-session-server erc-server-announced-name)))
+ (let ((server (or erc-session-server erc-server-announced-name)))
+ (dolist (l erc-autojoin-channels-alist)
+ (when (string-match-p (car l) server)
But its damage has already been undone by [3] (IOW, there's no
regression)! So everything's fine as long as we don't mind a bit of
churn for folks on master who may have adjusted their autojoin alists in
the meantime (since August 2020 or so).
I suppose if we *really* wanted to be thorough, we could add an entry to
etc/ERC-NEWS saying a problem introduced in early in Emacs-28
development has been fixed and that any entries in
`erc-autojoin-channels-alist' containing dialed host names as keys
should use networks or partial announced domains instead. But, IMO,
that's unnecessary.
Thanks, and apologies (yet again) for the noise.
[1] commit 927dcbd2e6e0e53fcfb09296716e11c002ab1518
Fix erc-join with channel password
[2] commit 88567ca8ecb505a59157af6338ebe355a304182b
Fix erc-reuse-buffers behavior
[3] commit 9bb8d90cddf11df3aecdc6c04e762773dfa0cb92
Allow irc network symbols in erc-autojoin-channels-alist
prev parent reply other threads:[~2021-11-22 1:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 0:15 28.0.50; ERC now ignores dialed server names in autojoin J.P.
2021-11-21 11:31 ` bug#52010: 28.0.60; " J.P.
2021-11-22 1:43 ` J.P. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='875ysl3qys.fsf__14463.3510777325$1637545460$gmane$org@neverwas.me' \
--to=jp@neverwas.me \
--cc=52010@debbugs.gnu.org \
--cc=emacs-erc@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.