Bug: org-agenda-set-tags with certain options sets tags on wrong entry [9.2.3 (9.2.3-13-g727c3f-elpaplus @ ~/.emacs.d/elpa/org-plus-contrib-20190506/)]

Bug: org-agenda-set-tags with certain options sets tags on wrong entry [9.2.3 (9.2.3-13-g727c3f-elpaplus @ ~/.emacs.d/elpa/org-plus-contrib-20190506/)]

[Allen Li]

Repro:

1. emacs -Q
2. Eval:

(setq org-tag-alist '(("agenda" . ?a)))
(add-to-list 'load-path "~/.emacs.d/elpa/org-plus-contrib-20190506")
(define-key global-map (kbd "C-c a") #'org-agenda)
(setq switch-to-buffer-preserve-window-point t)

3. Make a tmp.org containing:

* TODO foo
* TODO bar

4. Add tmp.org to agenda files.
5. Make sure point is on the foo entry.
6. C-c a t
7. Move point to the bar entry.
8. : a RET // Set agenda tag

Expected:

agenda tag set on bar entry

Actual:

agenda tag set on foo entry

More info:

switch-to-buffer-preserve-window-point interacts poorly with the
(delete-other-windows) call in org-fast-tag-selection.


Emacs  : GNU Emacs 26.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.8)
 of 2019-04-12
Package: Org mode version 9.2.3 (9.2.3-13-g727c3f-elpaplus @
~/.emacs.d/elpa/org-plus-contrib-20190506/)

Re: [O] Bug: org-agenda-set-tags with certain options sets tags on wrong entry [9.2.3 (9.2.3-13-g727c3f-elpaplus @ ~/.emacs.d/elpa/org-plus-contrib-20190506/)]

[Ihor Radchenko]

Allen Li <darkfeline@felesatra.moe> writes:

> Expected:
>
> agenda tag set on bar entry
>
> Actual:
>
> agenda tag set on foo entry

Just leaving a note that it is not reproducible with latest Org.

Best,
Ihor