From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Robert Pluim <rpluim@gmail.com>,
emacs-devel@gnu.org, john muhl <email@johnmuhl.mx>
Subject: Re: make check failing since 15693c81163e70b5df786e7c034bd236a40794bb
Date: Wed, 22 Dec 2021 16:26:55 +0100 [thread overview]
Message-ID: <875yrgbqyo.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkmnQEL8SHfJ5zqAEdb0hA_O=Sug=Q-gvJWjKrHJye8NJ0A@mail.gmail.com> (Stefan Kangas's message of "Wed, 22 Dec 2021 07:23:53 -0800")
Stefan Kangas <stefankangas@gmail.com> writes:
> Robert Pluim <rpluim@gmail.com> writes:
>
>> This is due to adding a binding in the minibuffer map, and not
>> updating help-tests-substitute-command-keys/keymaps
>
> We should probably make these tests less brittle.
Yup. Testing for the entire keymap (of keymaps that change, like the
minibuffer map) is too much work. It'd be better if the tests just
defined their own maps.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-12-22 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 10:33 make check failing since 15693c81163e70b5df786e7c034bd236a40794bb john muhl
2021-12-22 11:09 ` Robert Pluim
2021-12-22 15:23 ` Stefan Kangas
2021-12-22 15:26 ` Lars Ingebrigtsen [this message]
2021-12-22 22:11 ` Stefan Kangas
2021-12-22 18:20 ` john muhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yrgbqyo.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=email@johnmuhl.mx \
--cc=rpluim@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.