From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: Colourising tex keywords Date: Thu, 13 Jan 2022 00:30:23 +0100 Message-ID: <875yqo352o.fsf@zoho.eu> References: Reply-To: Emanuel Berg Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27960"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:KCN3tbPXkAAt/0DEWK8LJWG0jrg= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 13 00:31:45 2022 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7n5k-00079m-TR for geh-help-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 00:31:44 +0100 Original-Received: from localhost ([::1]:34584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7n5j-0006Qx-TA for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 12 Jan 2022 18:31:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7n4g-0006Fl-NY for help-gnu-emacs@gnu.org; Wed, 12 Jan 2022 18:30:40 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:57964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7n4Y-0005Bj-VX for help-gnu-emacs@gnu.org; Wed, 12 Jan 2022 18:30:36 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1n7n4X-0005eJ-J3 for help-gnu-emacs@gnu.org; Thu, 13 Jan 2022 00:30:29 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:135254 Archived-At: Jean Louis wrote: > (defun rcd-highlight-list (list) > "Uses LIST to highlight strings in buffer." > (hi-lock-mode) > (let* ((list (delete "" list)) > (highlights hi-lock-face-defaults)) > (while list > (highlight-regexp (regexp-quote (pop list)) (pop highlights))))) Probably "Uses" should be imperative "Use". There's no need for `let*' what I can see? It gets even more confusing with your use of "list" ... is it the argument, the let-binding, or the `list' function? Better to call the argument "lst" and use `let' unless `let*' is ... called for! Also the `while' test should be (and list highlights) since the highlights list is `pop'ped as well. Last Warning: reference to free variable ‘hi-lock-face-defaults’ -- underground experts united https://dataswamp.org/~incal