From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Zhiwei Chen Newsgroups: gmane.emacs.bugs Subject: bug#54384: 29.0.50; shell-resync-dirs failed to work Date: Mon, 14 Mar 2022 21:56:58 +0800 Message-ID: <875yog63it.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15284"; mail-complaints-to="usenet@ciao.gmane.io" To: 54384@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 14 15:16:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTlUW-0003op-1z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Mar 2022 15:16:08 +0100 Original-Received: from localhost ([::1]:38076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTlUV-0006YL-5C for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Mar 2022 10:16:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTlD0-0006JX-Le for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2022 09:58:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51986) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTlD0-0005Np-96 for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2022 09:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nTlD0-00025y-90 for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2022 09:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Zhiwei Chen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Mar 2022 13:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54384 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16472662297973 (code B ref -1); Mon, 14 Mar 2022 13:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Mar 2022 13:57:09 +0000 Original-Received: from localhost ([127.0.0.1]:45881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTlC8-00024W-KR for submit@debbugs.gnu.org; Mon, 14 Mar 2022 09:57:08 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:44212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTlC6-00024P-ON for submit@debbugs.gnu.org; Mon, 14 Mar 2022 09:57:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTlC6-0003og-FG for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2022 09:57:06 -0400 Original-Received: from [2607:f8b0:4864:20::52c] (port=35679 helo=mail-pg1-x52c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTlC4-0005CX-2n for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2022 09:57:06 -0400 Original-Received: by mail-pg1-x52c.google.com with SMTP id e6so13904645pgn.2 for ; Mon, 14 Mar 2022 06:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=AcNQeokagSFu5EqrQwwOOWlfPGiDLE6SKE+MY/i0dJc=; b=nWJqqlssVM/wCt+Nzw8q4FPzLZ+eEb8x/IhHmNc8Je5Pc92uOrByd1dPwqOjATWcC6 oueIRW/AqbXVQZc2+0SYZshvilJhmUlM9s+FYD9PPsxnOAtMo5w5uDvrtuh+cCcrrx81 igeRpLTmR2VnK0nRpCjuQGfBsr0WjL7oqb8mjmGK87jtB8Ow3C4jgH1tMvhTxuwf6Uqe A1jzzwe6fGGVaY7f4oSg6kKQtCuYm+YssGJnB0qvBYs7u1s7RbWS0LzE3E0Sfk94Mc/O 8h0Avwfabi6lZdpv5ZnAwtUlMe0taUKCl1CtdRJPjpLRgHvWjxlMxcmxGlDgA+3tNyPY zx0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=AcNQeokagSFu5EqrQwwOOWlfPGiDLE6SKE+MY/i0dJc=; b=WdiblsrNMWRiOb67juuDg2e/SPIKzyi4tTfF8dbBlXmMeQGCSmslznk4oImPtlhn2O R6FSkqPSpdAr3L6bIzroycNZdziEqwQWli1nNWcS+UgaBaVakQd7v1uki7bwzKQcLuHD 4wk454QZZ/m4aeq8SXRJBvZTYWQkG13BUB98adGHCfLEEEGa+cCzHSNUG6S1bCw37VzH 8FIGQjXWF4C+xhNlHw3moM6KmL8hd7RLyF8xO/EfmzP113HcISAQhc0qo5dNq4VBiYsB FlPLYVi3FY/aN62H0gN/lIx70CdlwuddB3Epmq7CwyTM1lqH7P5s9BhHnEugaauqyo85 38BA== X-Gm-Message-State: AOAM530ryFxUQSp1LTGWaDOhBOENwJuaXqGZWdVhdlT/OQyN+tAQvo+A 2OAQB1Gv4EiDLqhsWuNJJb2IOOeBT/+UPw== X-Google-Smtp-Source: ABdhPJwZ0H7LHhc/WDAuLDLz6YN0Nd4SPdo/WKswEWmFl0IqNwZEAoI0BwdSwyZi8F/1TFkaWctNXA== X-Received: by 2002:a05:6a00:174f:b0:4f3:fe06:61b5 with SMTP id j15-20020a056a00174f00b004f3fe0661b5mr23966519pfc.50.1647266222130; Mon, 14 Mar 2022 06:57:02 -0700 (PDT) Original-Received: from Youmu (192.69.92.236.16clouds.com. [192.69.92.236]) by smtp.gmail.com with ESMTPSA id lb1-20020a17090b4a4100b001bfb76e56d1sm16994377pjb.36.2022.03.14.06.57.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 06:57:01 -0700 (PDT) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52c (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=condy0919@gmail.com; helo=mail-pg1-x52c.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228365 Archived-At: How to reproduce: emacs -Q M-x shell RET M-x shell-resync-dirs RET Then Emacs will be unresponsive. Fortunately, C-g can quit the function. Before quitting, it's able to trace Emacs via perf. #+begin_src sh sudo perf trace -p $(pidof emacs) #+end_src The output tells Emacs is checking whether a path is directory, but it returns false. See the logs below. #+begin_src text 1898.605 ( 0.003 ms): emacs/889479 openat(dfd: CWD, filename: 0x5569b9323b80, flags: RDONLY|CLOEXEC|DIRECTORY|PATH) = -1 ENOENT (No such file or directory) 1898.623 ( 0.003 ms): emacs/889479 openat(dfd: CWD, filename: 0x5569b9323c50, flags: RDONLY|CLOEXEC|DIRECTORY|PATH) = -1 ENOENT (No such file or directory) 1898.639 ( 0.002 ms): emacs/889479 openat(dfd: CWD, filename: 0x5569b9323d20, flags: RDONLY|CLOEXEC|DIRECTORY|PATH) = -1 ENOENT (No such file or directory) 1898.656 ( 0.003 ms): emacs/889479 openat(dfd: CWD, filename: 0x5569b9323df0, flags: RDONLY|CLOEXEC|DIRECTORY|PATH) = -1 ENOENT (No such file or directory) 1898.673 ( 0.002 ms): emacs/889479 openat(dfd: CWD, filename: 0x5569b9323ec0, flags: RDONLY|CLOEXEC|DIRECTORY|PATH) = -1 ENOENT (No such file or directory) 1898.689 ( 0.002 ms): emacs/889479 openat(dfd: CWD, filename: 0x5569b9323f90, flags: RDONLY|CLOEXEC|DIRECTORY|PATH) = -1 ENOENT (No such file or directory) #+end_src Since I'm using zsh, `shell-resync-dirs' will send "dirs -l" to zsh process, then grab and parse the output. * Defect 1 After this while loop https://github.com/emacs-mirror/emacs/blob/f8cc706fb3d1ba30715c09aac9654ba08aeeb5c9/lisp/shell.el#L1072-L1074, the value of `dlsl` is '("-l" "" "dirs"), which means `shell-resync-dirs'' failed to grab/parse the output of `dirs -l'. * Defect 2 The while loop https://github.com/emacs-mirror/emacs/blob/f8cc706fb3d1ba30715c09aac9654ba08aeeb5c9/lisp/shell.el#L1078-L1092 can be infinite. When an element of `dlsl' doesn't exist, `file-directory-p' returns false, then no element of `dlsl' will be poped. An unintentional looping is happening. -- Zhiwei Chen