From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.devel Subject: Re: master d68ecda05c: Improve navigation keybindings in emacs-news-mode Date: Mon, 04 Jul 2022 17:38:14 +0530 Message-ID: <875ykd5bdd.fsf@gmail.com> References: <165685202989.19667.1306295129215761316@vcs2.savannah.gnu.org> <20220703124030.C769BC00BAF@vcs2.savannah.gnu.org> <87zghpi066.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32794"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Stefan Kangas To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 04 15:03:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8LjF-0007h9-Cu for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jul 2022 15:03:05 +0200 Original-Received: from localhost ([::1]:47454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8LYL-0002zS-Ca for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Jul 2022 08:51:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8KsO-0000qc-AY for emacs-devel@gnu.org; Mon, 04 Jul 2022 08:08:28 -0400 Original-Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:46710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8KsM-0006Vf-QH for emacs-devel@gnu.org; Mon, 04 Jul 2022 08:08:28 -0400 Original-Received: by mail-pf1-x441.google.com with SMTP id a15so8770667pfv.13 for ; Mon, 04 Jul 2022 05:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :user-agent:mime-version:content-transfer-encoding; bh=PEmE9E/zPPJYA8ODifdetfZpfF8Xb8mu1STEhVayOLY=; b=jUjpiOoy9KD47gqeGpXzvFln2Cq2tgIalkw/qN+BDMMr+JfYbVjG4+I2xqPzhHF5vs LWANEoyk34x31qdj3Tq7F86vwA01o6R6dgUDJ5X0mabr6ErWZxOjOEFjmVOjo2LOv3bd 7cveqVxt37O7Qt1RWXVvvI2sRA3sRswfWFYusa6lZbyQK5e4o8qNPD6LjOGfp6WV20wi UsMuqmvvSdqPxtzz/BWdJ7HOYOmkyLhJSe66kuXFi8Gh9gvanQSmd6g4ulSWKuXy810C 7w+rc7ge1vgSkP0cskcce9QgfslAIc2L8nyHiydJzuuzLxs8dCsvnLqOXLGUwExZR2i5 c0IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:user-agent:mime-version:content-transfer-encoding; bh=PEmE9E/zPPJYA8ODifdetfZpfF8Xb8mu1STEhVayOLY=; b=X0g5m16QTzdkU32EZT+4j3WfT/+pkF41+GL6LHcbZDtj1nmWUJSjakQnj5n2dKWtjA vntEJDRxuKT6Tl+Kee/5dPJUKzPmDmo+ZMnRsGUll1/VmY9dU9wZaN/+F3dHaR71fg9p yI8uW8ti6O5pnVqPy2oBdEQ/kSVyxFO7ghBzY5OIdjvCkyf/mUN80x0lidEGLX9ceMW/ XQ2/h5ZS+poljy+IaG8Zd6Cn/A/BruPvaTCqXloku19m5NyVigdmWROJK6/K/X1mLkvz PB08G94QIvSw3wXG9Y9s9yO+BE/dIUJWA1q2XHfwVtimNkkUcOJWfuy5ehKzTmmA8tTk MJzg== X-Gm-Message-State: AJIora94w89bV17nML5sV2/SjrM8kfGalbWfDSrq4H+wxZ3iD+LNUloE 4Cno7VX6RFdbSU5ZPQ5GoVKs6iKQyTk= X-Google-Smtp-Source: AGRyM1vt8ZKVvLDlVnSSYG6L7iTn7jYdoH7Qdr8RQ/Ep7NlYLaB8MuoROy9uXse6krF35IR8JgOSiQ== X-Received: by 2002:a63:100d:0:b0:411:8781:121a with SMTP id f13-20020a63100d000000b004118781121amr23397326pgl.583.1656936504879; Mon, 04 Jul 2022 05:08:24 -0700 (PDT) Original-Received: from localhost ([49.204.138.141]) by smtp.gmail.com with ESMTPSA id i1-20020a17090a718100b001ef87123615sm2240078pjk.37.2022.07.04.05.08.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 05:08:24 -0700 (PDT) In-Reply-To: <87zghpi066.fsf@gmail.com> (Robert Pluim's message of "Mon, 04 Jul 2022 13:31:45 +0200") Received-SPF: pass client-ip=2607:f8b0:4864:20::441; envelope-from=visuweshm@gmail.com; helo=mail-pf1-x441.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 04 Jul 2022 08:38:37 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291821 Archived-At: [=E0=AE=A4=E0=AE=BF=E0=AE=99=E0=AF=8D=E0=AE=95=E0=AE=B3=E0=AF=8D =E0=AE=9C= =E0=AF=82=E0=AE=B2=E0=AF=88 04, 2022] Robert Pluim wrote: >>>>>> On Sun, 3 Jul 2022 08:40:30 -0400 (EDT), Stefan Kangas said: > > Stefan> branch: master > Stefan> commit d68ecda05c4a634a1f0a606c73137d85bf261775 > Stefan> Author: Stefan Kangas > Stefan> Commit: Stefan Kangas > > Stefan> Improve navigation keybindings in emacs-news-mode >=20=20=20=20=20 > Stefan> * lisp/textmodes/emacs-news-mode.el (emacs-news-common-ma= p): New > Stefan> defvar-keymap. Bind navigation commands as in 'org-mode'= and > Stefan> 'outline-minor-mode'. > Stefan> (emacs-news-mode-map): Inherit from 'emacs-news-common-ma= p'. > Stefan> (emacs-news-view-mode-map): New defvar-keymap; inherit fr= om > Stefan> 'emacs-news-common-map'. > > Those outline-mode bindings are repeatable in outline-mode > itself. Wouldn=CA=BCt it be nice if they were in news-mode as well? (the > emacs-news-mode-map bindings I think don=CA=BCt need repeatability) > > So how about: Do you need the repeat-map? If I use an outline navigation command (like outline-up-heading), it triggers the repeat map for me in org-mode as well.