From: Po Lu <luangruo@yahoo.com>
To: Florian Rommel <mail@florommel.de>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Support fullscreen values fullheight and fullwidth on pgtk
Date: Fri, 08 Jul 2022 10:30:16 +0800 [thread overview]
Message-ID: <875yk85oav.fsf@yahoo.com> (raw)
In-Reply-To: <c52891dceba589f8abf9540a646478c7beb59528.camel@florommel.de> (Florian Rommel's message of "Thu, 07 Jul 2022 20:52:53 +0200")
Florian Rommel <mail@florommel.de> writes:
> On Mon, 2022-07-04 at 10:20 +0800, Po Lu wrote:
>> Thanks, now installed.
>
> Unfortunately, I just discrovered that the change causes a problem with
> `toggle-frame-fullscreen'.
>
> `toggle-frame-fullscreen' saves the current window state and tries to
> restore it. Because GTK does not support setting fullheight or
> fullwidth (and we therefore ignore these values in (set-frame-parameter
> 'fullscreen)), we cannot change back once the fullscreen state changes
> from 'fullheight or 'fullwidth to 'fullboth.
>
> Apart from reverting the commit, we could fix this by setting the
> 'fullscreen parameter to nil and restoring the frame (this is the
> closest to fullheight and fullwidth we can get with gtk), see the
> attached patch.
Actually, I think we need a more general mechanism to report which
`fullscreen' states can be set, and then to use that in
`toggle-frame-fullscreen' (and other places that set the
`fullscreen-restore' frame parameter.)
So this:
(if (memq fullscreen-restore '(maximized fullheight fullwidth))
would probably become
(if (display-supports-fullscreen-p fullscreen-restore)
WDYT?
next prev parent reply other threads:[~2022-07-08 2:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 14:57 Support fullscreen values fullheight and fullwidth on pgtk Florian Rommel
2022-06-02 6:00 ` Po Lu
2022-06-03 8:11 ` Florian Rommel
2022-06-03 8:23 ` Po Lu
2022-06-03 18:42 ` Florian Rommel
2022-06-04 1:17 ` Po Lu
2022-06-04 14:03 ` Florian Rommel
2022-06-05 1:06 ` Po Lu
2022-06-05 5:41 ` Eli Zaretskii
2022-06-05 10:41 ` Florian Rommel
2022-07-03 11:08 ` Florian Rommel
2022-07-03 11:37 ` Po Lu
2022-07-03 11:39 ` Florian Rommel
2022-07-04 2:20 ` Po Lu
2022-07-07 18:52 ` Florian Rommel
2022-07-08 2:30 ` Po Lu [this message]
2022-07-08 5:49 ` Eli Zaretskii
2022-07-08 6:34 ` Po Lu
2022-07-08 7:10 ` Eli Zaretskii
2022-07-08 7:37 ` Po Lu
2022-07-03 13:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yk85oav.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mail@florommel.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.