From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Akib Azmain Turja Newsgroups: gmane.emacs.devel Subject: Re: [C source] Inconsistent comments on preprocessor conditionals Date: Fri, 08 Jul 2022 19:55:05 +0600 Message-ID: <875yk73e12.fsf@disroot.org> References: <87sfnb3h5m.fsf@disroot.org> <8335fb4vc7.fsf@gnu.org> <6feb2ce2c5e249b74e836edd3ba0c7a0@webmail.orcon.net.nz> <83y1x33eum.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22297"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii , Phil Sainty Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 08 15:56:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9oTL-0005Vz-4v for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jul 2022 15:56:43 +0200 Original-Received: from localhost ([::1]:48438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9oTJ-0007zV-Pl for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jul 2022 09:56:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9oS5-0005ZP-70 for emacs-devel@gnu.org; Fri, 08 Jul 2022 09:55:25 -0400 Original-Received: from knopi.disroot.org ([178.21.23.139]:47160) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9oS3-0002tA-H5; Fri, 08 Jul 2022 09:55:24 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id DDFFA40E63; Fri, 8 Jul 2022 15:55:21 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 011aNjC6W1_8; Fri, 8 Jul 2022 15:55:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1657288520; bh=K1hJfpCeZ8khi/Y6QDyKQyS66rr/cjK01LwTxPyO0rE=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=erzjA3Yk/OEITZIlwruhmyp1vapU0qfKGemSjB3rXQh67seDMSOyHYiiojfRZ43x7 f2/SiYMN9mIw9SLmHOBWrlEAeD0vn+RC19dZW7tSMci5qCMwN2BHVOYEhMeoGEBpqP mwcycTOOQnSXo5L7EChzF/ZtiwxRP51IGYzE7qeyypBqJ4FoaIK72EUewX3vrCQCtr ZOw0EXC4h7lHsDrzSLF10sI8uE9GqS7FrEStQTDAFE10PRqrVSldRmQwKlQsVlzfI6 1vA0NgrWd7ZSaSUl9A8vW6Tv2SYOkXKtoCOJCTPyhjeYmvSfY+H3C7718QQztxkveg Yafsny1B0WAyw== In-Reply-To: <83y1x33eum.fsf@gnu.org> Received-SPF: pass client-ip=178.21.23.139; envelope-from=akib@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291969 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> Date: Sat, 09 Jul 2022 01:33:26 +1200 >> From: Phil Sainty >> Cc: Akib Azmain Turja , emacs-devel@gnu.org >>=20 >> On 2022-07-09 00:55, Eli Zaretskii wrote: >> > You mean, the comment for the #endif line? It doesn't really matter >> > how you comment that, because both comments tell the same: the >> > #ifdef'ed conditional block ends here. The differences in this case >> > are purely stylistic. >>=20 >> The "#endif /* not FOO */" version provides the extra information that >> there *is* an "#else" clause > > No, it doesn't, because the conditional could start with #ifndef > instead. Then we can do like the following: =2D-8<---------------cut here---------------start------------->8--- #ifndef FOO ... #else /* not !FOO */ ... #endif /* not !FOO */ =2D-8<---------------cut here---------------end--------------->8--- Very confusing though. =2D-=20 Akib Azmain Turja This message is signed by me with my GnuPG key. It's fingerprint is: 7001 8CE5 819F 17A3 BBA6 66AF E74F 0EFA 922A E7F5 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEyVTKmrtL6kNBe3FRVTX89U2IYWsFAmLINzkACgkQVTX89U2I YWtBuQ//WXofTCcWH+rUeLtt1wSmrgCDL6EQBjy4m/J70vyamqSh2R09DosUKOhr wKEUb176Gaj2mvFdXiujDPZ9MDUyclpQRNGuOPam+JsHWFFQyxOtCIKroqiyO58q pfc+hbDY1A9FK8ist6RS3DttqfUHdzdC6Q3ay1lELuipmOWGPVX45xpubD65fjM4 hpC0KtDivVdD+S2ONUWG6xjeA2ddcToytAvGEbbbCvgx+5cKhIS4yxrro9n4o0rC hdOCYPdyTPzEvOaEcBZ6fo8ocmEdQZUErXJwnUnu104sQ7FWwY/5Oc7Q1MJ4WDLW wuCVY1OMB3twFdbtY0iySTrpujntWlYn3rzY4FhIsoAqtVFEDNav/mfkECnquJm/ 8//N4Hn91KuxOPqnXoojaVupHCdBCT1C/z0yaMMwzBymVugjAZVC4B0S4jgiMLpQ lbLyi4RErNTwCgKiNgZ2t2tJHDKHoDM/z1gRxHBT3R4NdjMio7vxYTLJFtqILXic IlwnANh8t4GJuIdN5qKM0+8lqMBoyr3gameTi9KYkzKP8GibdTp9H11QlHe+CBJP EMKSNtGPyt1lqXA22p8c2Hyvh8ROh0G+WoSRML5ITGPTApL723nQ15Vl+OL66Q3Q 9eBCfI0GXjhX1pQd7DV2aeE9ZgYw8KY+lxfpeYAxuID08QaTt+U= =hf6e -----END PGP SIGNATURE----- --=-=-=--