From: Po Lu <luangruo@yahoo.com>
To: Daniel Colascione <dancol@dancol.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 4b98a79a50: Improve X event timestamp tracking
Date: Sun, 07 Aug 2022 12:23:34 +0800 [thread overview]
Message-ID: <875yj4znp5.fsf@yahoo.com> (raw)
In-Reply-To: <19d020d85bed5d030e706800f8cbb0b7fbb3bc65.camel@dancol.org> (Daniel Colascione's message of "Sun, 07 Aug 2022 00:03:57 -0400")
Daniel Colascione <dancol@dancol.org> writes:
> I've contributed code all over this project and never been limited by
> MAINTAINERS. This file does not grant you the authority to
> arbitrarily reject contributions that fix long-standing bugs. You're
> welcome to make improvements to committed code just like anyone else.
> I'd suggest minimizing friction in the future, not blocking useful
> work form someone who spent all day debugging this issue.
I have not arbitrarily rejected anything. I've told you why this isn't
a good idea, yet you proceeded to install the change anyway. Please, no
rush!
> An "entire terminal hook" is a trivial function pointer.
> Don't you think this is a mountain out of a molehill? What,
> precisely, is the resource being consumed by minimizing terminal hook
> structure fields?
Consider the following situation: a programmer is writing some code and
notices that `x-focus-frame' is not working. But the doc string says it
should work, without calling magic functions to note "out-of-band
interaction".
I'm not concerned about how many bytes a terminal hook takes. I'm
concerned about exposing a clean abstraction over the window system to
users and programmers working on display-independent parts of Emacs.
> Sure, we could have open-coded typecases or inscrutably invocations
> of some "force" parameter --- or we could make a generic terminal
> operation that clearly and explicitly expresses user intent. It's not
> as if the X event timestamp mechanism exists without reason either.
The X server clock exists to provide orderly synchronization of input
focus and selection ownership. Ensuring Emacs works with that
synchronization isn't the job of Lisp code in server.el or C code in
termhooks.h, it's the job of C code in x*.c.
> Focus-stealing prevent isn't some "draconian" measure to work around
> or a bug in window managers, but instead a way to properly order
> events observed in a distributed, asynchronous system.
Focus stealing prevention is a draconian measure to ensure that programs
in the background do not suddenly move themselves into the foreground.
Which works, until it doesn't, like with the Emacs server.
> You're proposing scrapping a generic mechanism and replacing it with
> a special case, and I don't right now see the net benefit.
Because that generic mechanism exposes low-level window system
implementation details to users. The Lisp programmer shouldn't need to
know he must call two functions, instead of one, to ensure that
x-focus-frame results in a frame being activated, which defeats the
whole point of Emacs abstracting over the window system.
next prev parent reply other threads:[~2022-08-07 4:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165984385935.14715.8191942019361575877@vcs2.savannah.gnu.org>
[not found] ` <20220807034419.B5F2FC09BFD@vcs2.savannah.gnu.org>
2022-08-07 3:46 ` master 4b98a79a50: Improve X event timestamp tracking Po Lu
2022-08-07 3:48 ` Daniel Colascione
2022-08-07 3:51 ` Po Lu
2022-08-07 4:03 ` Daniel Colascione
2022-08-07 4:23 ` Po Lu [this message]
2022-08-07 4:39 ` Daniel Colascione
2022-08-07 5:26 ` Po Lu
2022-08-07 5:43 ` Daniel Colascione
2022-08-07 6:07 ` Po Lu
2022-08-07 6:25 ` Daniel Colascione
2022-08-07 6:41 ` Po Lu
2022-08-07 6:55 ` Daniel Colascione
2022-08-07 7:06 ` Po Lu
2022-08-07 5:41 ` Eli Zaretskii
2022-08-07 5:51 ` Daniel Colascione
2022-08-07 5:53 ` Po Lu
2022-08-07 6:04 ` Daniel Colascione
2022-08-07 6:15 ` Po Lu
2022-08-07 6:43 ` Daniel Colascione
2022-08-07 7:02 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yj4znp5.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.