From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Date: Sat, 17 Sep 2022 13:17:47 +0200 Message-ID: <875yhmckro.fsf@gmail.com> References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> <87bkrlq3ar.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36106"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 57725@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 17 13:18:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZVqY-0009DC-R4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 13:18:54 +0200 Original-Received: from localhost ([::1]:40146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZVqX-0002aZ-FL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 07:18:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZVpj-0002BF-Ct for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 07:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZVpj-0005aC-5L for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 07:18:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZVpi-0005lM-Us for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 07:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2022 11:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs Original-Received: via spool by 57725-submit@debbugs.gnu.org id=B57725.166341347822131 (code B ref 57725); Sat, 17 Sep 2022 11:18:02 +0000 Original-Received: (at 57725) by debbugs.gnu.org; 17 Sep 2022 11:17:58 +0000 Original-Received: from localhost ([127.0.0.1]:45259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZVpe-0005ks-AV for submit@debbugs.gnu.org; Sat, 17 Sep 2022 07:17:58 -0400 Original-Received: from mail-ej1-f47.google.com ([209.85.218.47]:37421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZVpa-0005kH-VZ for 57725@debbugs.gnu.org; Sat, 17 Sep 2022 07:17:55 -0400 Original-Received: by mail-ej1-f47.google.com with SMTP id a26so25968803ejc.4 for <57725@debbugs.gnu.org>; Sat, 17 Sep 2022 04:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=cqZDRWbrqsQkOnF1D4FYABapmAWTwPw0dJixUfftMOI=; b=Gv2v8a+iRqn8iguYZ2zNqRFkL41WuiheG0pgGR2CMwk9THsh97vqz6oUqvx25+vvwr pTIjJOGc7Edbi/HVAlSkM30NLwYGBUq5hPjDmsUm8YTcbSEmvbxxq045muUj+/8Rgl0o LTPDf6HGsRUddXskdLENkqU7xwNRJqgpXohY4dbArYe6YY4IjW6sYmOTAbOO1zPy2oM0 i1IqTDE2mcNQ64mbnp3SZGnD+7jdk6DAf+CYT8vMw8CPL3opiC9zwDoVRFqnvv9sY1tE iPl7HE6ffCsdKhycJAlmGukd0mXY5ODCF3cEAgbUKaLf0u8YZ3yp25IpN+2SAKDGeSqj uS5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=cqZDRWbrqsQkOnF1D4FYABapmAWTwPw0dJixUfftMOI=; b=fU7mDDWKZkFb9anjKPLaXpQW6PpYgq546ohVXymqsRln7kSF+xOCrVa5v1XVk2nCv0 XzcVzW9h7EaC7tJFv9XleX57hneGQzCIqeAUe1WElhgrpcQcT57aoxYt+O7sNnbyOVbB KkFwBFysZmkLwwSfrWoMN3lkeWM8XPaiu5cnjWYwiD8n/ozbpNs710TYL367jbKD8OY5 4g9fFzYaavSwVSF7zxU46jPNj9KK+nOyQS9LEkj0LU9qklw+wQ4kWSIWIBKVs9/+K3Qa 8DgAEi2BW97NPp5SaczQU/jnyxMmGNP0ujhKUSxM2wv2oKDuIEa0ENjGFN2+qrvg1Xir vhKA== X-Gm-Message-State: ACrzQf15HG581AME/OsRhe5wy1C6OymPiQvPyEjJNkhp9ywnzDg81ye5 mgXPn05E3ElcYgmNZR6hr+qy9ptZMX20Aw== X-Google-Smtp-Source: AMsMyM6qvLDf25E1dLBwnrNQzKMnnIzuLQBEYUx5gZ0zvr+WJnKx5MMOp5t1DtuNY4YswoeZkIhUlQ== X-Received: by 2002:a17:907:eaa:b0:772:b571:bd7c with SMTP id ho42-20020a1709070eaa00b00772b571bd7cmr6277126ejc.563.1663413468597; Sat, 17 Sep 2022 04:17:48 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::8510]) by smtp.gmail.com with ESMTPSA id d18-20020a170906305200b0073d81b0882asm11989946ejd.7.2022.09.17.04.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Sep 2022 04:17:48 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 11 Sep 2022 17:38:09 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242861 Archived-At: I just submitted a pull request on Github, so that we can see the CI test results. https://github.com/joaotavora/eglot/pull/1038 I guess we can close the ticket there and continue the discussion there. On Sun, 11 Sep 2022 at 17:38, Jo=C3=A3o T=C3=A1vora wrote: > Yes, makes sense, but there is another piece of initialization -- good ol= command line > params -- that are also treated the way i described (i'm almost sure, but= better confirm). > > So it's good to be consistent. If this kind of refreshing from user optio= ns is needed for > debug purposes, the user can simply shutdown and restart instead of eglot= -reconnect. At > least this is what I figured at the time. > > On Sun, Sep 11, 2022, 17:33 Augusto Stoffel wrote: > > On Sun, 11 Sep 2022 at 17:27, Jo=C3=A3o T=C3=A1vora wrote: > > > Can you suggest an alternative patch so that that second effect also h= appens? > > > > Jo=C3=A3o > > > > On Sun, Sep 11, 2022, 17:26 Augusto Stoffel wrot= e: > > > > On Sun, Sep 11, 2022, 18:20 Jo=C3=A3o T=C3=A1vora wrote: > > > > I almost agree with this fix as is, but maybe we should name the slot= . What > > happens if my the connection is restarted, shouldn't the previous > > initializationOptions be reused? > > > > Most certainly. > > Actually, I'm not so sure what the best behavior is. I think reusing > the original :initializationOptions is consistent with other behavior in > Eglot (is it?), but there's also merit in recomputing/using the current > user settings =E2=80=94 for instance, if you need to debug the > :initializationOptions.