From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@gmail.com>
Newsgroups: gmane.emacs.bugs
Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server
Date: Thu, 10 Nov 2022 22:48:20 +0000
Message-ID: <875yfm8lzf.fsf@gmail.com>
References: <cc9a957a-83b5-9c86-ad13-87ecaf44dcb1@dfreeman.email>
 <CADwFkmmp6RfDC0-PpdPMuLExZGe7WBH+q=TX24WQ7_Ko7NgYSw@mail.gmail.com>
 <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email>
 <87ilk5xq01.fsf@gmail.com>
 <f39bd6fa-903d-1723-8ec2-d7ffff4d4a9c@yandex.ru>
 <87r0yrwfn3.fsf@gmail.com>
 <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru>
 <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email>
 <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email>
 <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email>
 <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com>
 <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email>
 <CALDnm502ZQX8CpYjoYPj_D4h3khH=CDEnoUvZ6t0f+qLQJmpAg@mail.gmail.com>
 <87fseqtpiu.fsf@dfreeman.email>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="25029"; mail-complaints-to="usenet@ciao.gmane.io"
User-Agent: Gnus/5.13 (Gnus v5.13)
Cc: Eli Zaretskii <eliz@gnu.org>, dgutov@yandex.ru, felician.nemeth@gmail.com,
 58790@debbugs.gnu.org, stefankangas@gmail.com
To: Danny Freeman <danny@dfreeman.email>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 10 23:48:28 2022
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1otGLU-0006DI-7F
	for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Nov 2022 23:48:28 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1otGLC-0002o3-Qp; Thu, 10 Nov 2022 17:48:10 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1otGL5-0002ji-HN
 for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 17:48:04 -0500
Original-Received: from debbugs.gnu.org ([209.51.188.43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1otGL5-00059s-2e
 for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 17:48:03 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1otGL4-0006Fd-E2
 for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 17:48:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=
 <joaotavora@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Thu, 10 Nov 2022 22:48:02 +0000
Resent-Message-ID: <handler.58790.B58790.166812043723866@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 58790
X-GNU-PR-Package: emacs
Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166812043723866
 (code B ref 58790); Thu, 10 Nov 2022 22:48:02 +0000
Original-Received: (at 58790) by debbugs.gnu.org; 10 Nov 2022 22:47:17 +0000
Original-Received: from localhost ([127.0.0.1]:44599 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1otGKK-0006Cs-O3
 for submit@debbugs.gnu.org; Thu, 10 Nov 2022 17:47:16 -0500
Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:41898)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joaotavora@gmail.com>) id 1otGKG-0006Cc-3N
 for 58790@debbugs.gnu.org; Thu, 10 Nov 2022 17:47:14 -0500
Original-Received: by mail-wr1-f43.google.com with SMTP id w14so4256108wru.8
 for <58790@debbugs.gnu.org>; Thu, 10 Nov 2022 14:47:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; 
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=qDmHQGf6DS+lFV6DI3TH9sA7SpbMIuD9MtoGmVuahbU=;
 b=LWg5C/nnMl3xU4QvxO57tVS10+7wgVTQtuZ5VhiNt4nrCuCuKACcw+wkpPFqyFolsd
 NKpcqNVbL2F0vvUad9i1/t1bhD+rgWB/vHdYL3MeF6fhhGb14v3aUameuSKerPShk2wW
 jn7Ph9vMHuBKHR+W36Zqgla3+5HkabTb/+3KeikS4OklAwafwB3oMKyYh2huuZGTt7M3
 Li3DPm00ktt8MoeQO+5wRC1tEUKstGiLqZ9MdNnFB1pq0HOnj0hBEanORUr6RJ5OrvyB
 KgErgTYDWGfVZifQr4UI5S678jq54v7aV0rkup+UDksi1aBWTx3427UJ2CxUMWuIj0Ul
 qDiA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=qDmHQGf6DS+lFV6DI3TH9sA7SpbMIuD9MtoGmVuahbU=;
 b=1oUBvGxpGYdfHqlthJWZg2xJUAfFCYUIst2N4PGNRx1sa6Xwfj/4oCswzDIoduv8T7
 mCXv7stWS3e0yRuh59zh1TCgw8IbRKvgbheKYsxjxrGIFJPfN4x0xKDgjsdrkn/CLCIi
 3UVcZlC1L3E/Q0bsiIIL1u99Zqzb8HAvulgahrB9wBXPG+DhAJ/T2uZw68hhfrWZeyi2
 EO3uWpEOjr1VfnRCqy+qDK1HS5pYnsK9alfcBQAASY39ROrD8gVX+RTTq77b7ZxuCqy4
 Vebuq4X7aX71KQjinLxeQjPHkKt7xhQo2Jnxuud7OUbTzQbFuSCoE2MZ9Y3Myk3Y4Xz8
 Z07A==
X-Gm-Message-State: ACrzQf3MrYqqe3wbsfNNESFMcpLw9zOGj75dUEy6odzAcSgtd4rPivWc
 mpkqP1MfagFH8/rNk+P0YWs=
X-Google-Smtp-Source: AMsMyM7DjyaVA9oeoB522Lc0JOORKxyM2g6chybJWMVoqtAUa3EEqE/Wz6i/Srx7dH7L/2iynEDlqg==
X-Received: by 2002:adf:a31c:0:b0:236:ba0d:246b with SMTP id
 c28-20020adfa31c000000b00236ba0d246bmr39998526wrb.448.1668120426159; 
 Thu, 10 Nov 2022 14:47:06 -0800 (PST)
Original-Received: from krug (87-196-81-1.net.novis.pt. [87.196.81.1])
 by smtp.gmail.com with ESMTPSA id
 l26-20020a05600c2cda00b003cf774c31a0sm6952135wmc.16.2022.11.10.14.47.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 10 Nov 2022 14:47:05 -0800 (PST)
In-Reply-To: <87fseqtpiu.fsf@dfreeman.email> (Danny Freeman's message of "Thu, 
 10 Nov 2022 17:22:15 -0500")
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:247558
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/247558>

Danny Freeman <danny@dfreeman.email> writes:

> In reviewing the comments over and over I've made a modification to
> the second patch involving the warning message. Instead of using an
> arbitrary symbol I realized that the function `find-file-name-handler'
> works when a nil value for the second argument (operation).

I've now pushed the first patch, but I held off the second patch.

I don't see this OPERATION=3Dnil option documented in the docstring of
find-file-name-handler, so I'm not sure we should rely on it.

I think we should provide OPERATION here, because what we want to check
is if we, Emacs, can actually visit the file designated by the URI.  So
I think passing something like 'access-file' as the OPERATION argument
makes more sense.  But Eli probably has more knowledge here.  Maybe
passing nil is indeed correct.

Jo=C3=A3o