From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/idris-mode e7e2a6c3bc 3/8: Remove dependency on if-let* defined in subr-x Date: Fri, 11 Nov 2022 16:00:51 +0000 Message-ID: <875yfl32h8.fsf@posteo.net> References: <166816793805.30580.17048508686295430872@vcs2.savannah.gnu.org> <20221111115858.91A0EC0E4CB@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15514"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Marek Labos To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 11 17:01:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otWTU-0003pp-EG for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Nov 2022 17:01:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otWSu-00031n-UO; Fri, 11 Nov 2022 11:01:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otWSo-00031X-NZ for emacs-devel@gnu.org; Fri, 11 Nov 2022 11:01:07 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otWSh-00021c-9S for emacs-devel@gnu.org; Fri, 11 Nov 2022 11:01:06 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C9EFE240028 for ; Fri, 11 Nov 2022 17:00:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668182455; bh=VV0hec+5FnzRNsPL7OZMmauzhpQggokTLRvKUgbfb2I=; h=From:To:Cc:Subject:Date:From; b=SIH6NJo5HDXCuyzlaOg2IF1CTYQngA1h+nxKcpZyzLXSfyEpTJX4msupbg6+Ld1+h gtsxkn531yK7TW2dFlNbVYnTEhWoQ4DHg7JYN7tTNA0IVzpjOXQx+je6JAUCeneVkc aoY0PjL3jJqiUrhGUUNJOWUxm1zlJ4mLQlRfDpX7MFkc9n/SsaLjo4i1tDLliXyQsh eDqhqnTPuQ4qMjoMxF8b8lTckPJgIvZO8TxGej8dqVKhkTdh7uaVF+w9xy9+cixziM 5TzxjdjM2OkhPf4EpkAJjn3+iJjB97I1JWs+4AewxhbQREZ9WZ3D3RNj/P9ab2Xjit 1znkBHgNGWM6A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N83Mm2mtWz9rxB; Fri, 11 Nov 2022 17:00:52 +0100 (CET) In-Reply-To: <20221111115858.91A0EC0E4CB@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Fri, 11 Nov 2022 06:58:58 -0500 (EST)") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299575 Archived-At: ELPA Syncer writes: > branch: elpa/idris-mode > commit e7e2a6c3bc56a72b3edb8dedef7f4b3c63bcd1f8 > Author: Marek Labos > Commit: Marek Labos > > Remove dependency on if-let* defined in subr-x > > Why: > to test if this fixes issue `(seq-find .. ) is a malformed function` > https://github.com/idris-hackers/idris-mode/pull/558#issuecomment-1307149527 > --- > idris-commands.el | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/idris-commands.el b/idris-commands.el > index 9e77008042..a11bba322a 100644 > --- a/idris-commands.el > +++ b/idris-commands.el > @@ -960,11 +960,12 @@ Inspired by `cider-switch-to-last-clojure-buffer' > https://github.com/clojure-emacs/cider" > (interactive) > (if (derived-mode-p 'idris-repl-mode) > - (if-let* ((a-buf (seq-find > - (lambda (b) (eq 'idris-mode (buffer-local-value 'major-mode b))) > - (buffer-list)))) > - (pop-to-buffer a-buf `(display-buffer-reuse-window)) > - (user-error "No Idris buffer found")) > + (let ((idris-buffer (seq-find > + (lambda (b) (eq 'idris-mode (buffer-local-value 'major-mode b))) > + (buffer-list)))) > + (if idris-buffer > + (pop-to-buffer idris-buffer `(display-buffer-reuse-window)) > + (user-error "No Idris buffer found"))) > (user-error "Not in a Idris REPL buffer"))) > > (defun idris-quit () Are you sure that subr-x was loaded? It is usually best to have a (eval-when-compile (require 'subr-x)) at the top of the file so that those macros get simplified away at compile time.