bug#58447: [PATCH] In project-find-file, add absolute file name to history

[Augusto Stoffel <arstoffel@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

On Wed,  2 Nov 2022 at 00:14, Dmitry Gutov wrote:

> On 01.11.2022 19:30, Juri Linkov wrote:
>>> I'm not quite sure what Juri meant here.  If from some project I do
>>>
>>>    C-x p f /tmp RET RET
>>>
>>> then Emacs opens the /tmp dired buffer (RET twice because REQUIRE-MATCH
>>> is 'confirm), as I think it should.
>> Actually, that [Confirm] part is not quite a hassle, so your patch
>> already handles that in both ways, thanks for this.
>
> Thanks for verifying.
>
> LGTM then.

FTR, someone would have to install the patch on my behalf.  I've
attached it again for your convenience.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-In-project-find-file-and-the-like-add-absolute-file-.patch --]
[-- Type: text/x-patch, Size: 1724 bytes --]

From 699732687f559c7984e76310971094f251423d5d Mon Sep 17 00:00:00 2001
From: Augusto Stoffel <arstoffel@gmail.com>
Date: Tue, 11 Oct 2022 20:21:34 +0200
Subject: [PATCH] In project-find-file and the like, add absolute file name to
 history

* lisp/progmodes/project.el (project--read-file-cpd-relative): Add
absolute file name to history.
---
 lisp/progmodes/project.el | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index ee94d0d85d..95087ae6a8 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -931,11 +931,15 @@ project--read-file-cpd-relative
          (_ (when included-cpd
               (setq substrings (cons "./" substrings))))
          (new-collection (project--file-completion-table substrings))
-         (res (project--completing-read-strict prompt
-                                               new-collection
-                                               predicate
-                                               hist mb-default)))
-    (concat common-parent-directory res)))
+         (relname (let ((history-add-new-input nil))
+                    (project--completing-read-strict prompt
+                                                     new-collection
+                                                     predicate
+                                                     hist mb-default)))
+         (absname (expand-file-name relname common-parent-directory)))
+    (when (and hist history-add-new-input)
+      (add-to-history hist absname))
+    absname))
 
 (defun project--read-file-absolute (prompt
                                     all-files &optional predicate
-- 
2.37.3