From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 00de296d1b 3/3: Simplify erc-sasl's auth-source API Date: Tue, 29 Nov 2022 14:07:56 +0800 Message-ID: <875yeywawz.fsf@yahoo.com> References: <166969908095.16328.16275737650099622826@vcs2.savannah.gnu.org> <20221129051801.9344CC0009E@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19650"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: "F. Jason Park" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 29 07:09:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oztnp-0004p5-FZ for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Nov 2022 07:09:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oztn1-0008IE-TL; Tue, 29 Nov 2022 01:08:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oztmx-0008I6-Fs for emacs-devel@gnu.org; Tue, 29 Nov 2022 01:08:15 -0500 Original-Received: from sonic305-20.consmr.mail.ne1.yahoo.com ([66.163.185.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oztmv-0003My-ND for emacs-devel@gnu.org; Tue, 29 Nov 2022 01:08:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669702089; bh=BQm3odUntXXNmpBaeH22Hrhy87Ddti4Xo3ooTeJih/g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=nLPqNv4PX4DcVw4ZsSd0s1grRzQjteEQZrZ+sITkPVnECj5x7cTu2rw3TjsmqiNLoz7nTIdVxrmFqZYrmml429EkUtU0H7JlIYTf79zhInBzpp9fZJHkMQS4KygDFL+uiuWvmRcoJEVunXxoKPPhIiNOt+ER7QlVCm/NgVMohoHHrlu1j3Q0sfG0kelLX8Foct1XQPTHG3tiIb/webwXcQxTMTS61DTVsbKx/49dzTWUvRUjbGXJ+Mw1J17PS/Kp8gQbDokXUhX4dU4AuqEaTMeKXNUqdzfBAzz7O4vJ8hcIT1XaF0XU9TGWtmncrhaEJEcYst10z8EcKKAb7VJryw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669702089; bh=vtUny4HirNBNeDquybAmNm3X94cHIJ/t5NgqKpE27aP=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=WjbgsAgKSXGQfKlKbEp3DFkyMXaeXnKK0SZFFMaWY7HAc0Fp5chMDU9qk39viTUoS2gH1t0GNtavJ8yDzjDEeXR3zklhPj/mFdNveB1ysSy5w5kvqSRPOhWEbirEdZZ4U+QTcAfifDC7a/i41I1bloQGWySmspMf5U/a5uZAos0LiPoY5O/SUqKXLGrlCqqMlbQ+eWN/RinY8pErovbGTjIwfADtBpg9u0o7WiGVF63ntMuriqhU91c9gxIqSstVwKeh8cLBzoxNMhP6Bbpl1YN+J2auTJw3xixurXw47Zk7Q1rK68jTSQmkgNaerQTUitQWgCx1iHcR4Tc9MVgTuQ== X-YMail-OSG: zP_fOwYVM1lJZ3cW07kKiJ3bMYZb4yUXpCOlBTLkmwtwMV.8chrgRY41uytiReb d5IHKrYsqGMUqrGZLtcc0ECprtXN6Y3hW5HdgUSL3cff57lfE5VdFIxEmJ0nD0kqhDwUAgqqlirv 7URmpdYMCFG6eQ2o7gqQPtA57b796CR5vjHpvQZXezv6dttrXCR3EnRPMryypHPivWU2Dpcp9vRm aw6tOJ7uXkSsCGzISMSbSvq8QTMpBVMxl3OQ1GzfFXw7.XceRk8gt0_aU71IDIn1zr21Fr8PID5t T4gX0OFXGumx4_knM_nY2REAq8X1bI247N90MnVJwGmdP0kYKbFxIK_YHctyX78lJU7iTcHnRq1T 6nbsBySkgG3t741lgyG1PfzX9w8tsN59S4df7qRnAdsoW88J9KjfBpb60qd7Kf3zVP5It5t5zUJt DoYLxa46XL6LNVcgZZlCKbJ9eJxy9Uqt2p7yggKp76.ggOWwBas4Mqcso3UjJ_Lwm6nOw669ybjv 6MV.Wx20r6HFA_XL0Cs.1tS5HXuppTt49BCZyvXneAw2Lql6jCtZvyoswTldqE5T9_XATvz0d7eN opezBfVH3HBt6kY0woCY6GnB._T61XgtzLiT2AaBI2hTcPC2kgkauVMdDtIc2NGMpfbUGRLFs8Ax IBEADC32o4OjD6vvpWbb9uf.9kmuasPOz4r_ZT.eJ4yh7Mu2nb8O0jqCk5raNXkqGDlw8cirKTqv QZZym7UGNZ2jLz8RB3_b4Aeqpuj7ZDE9s_zHjnPsA003Qa4wn8lNY6uO7MI5RG6YsrqJovIw1nno A.nDqOcjLNdfTx9D91cZkDDuWM5v.PGJNwz2jAyrDe X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Tue, 29 Nov 2022 06:08:09 +0000 Original-Received: by hermes--production-sg3-6c8895b545-pb7wm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6fe2eb8763599c286bf29d90fcb6c97e; Tue, 29 Nov 2022 06:08:03 +0000 (UTC) In-Reply-To: <20221129051801.9344CC0009E@vcs2.savannah.gnu.org> (Amin Bandali's message of "Tue, 29 Nov 2022 00:18:01 -0500 (EST)") X-Mailer: WebService/1.1.20863 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.146; envelope-from=luangruo@yahoo.com; helo=sonic305-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300700 Archived-At: Amin Bandali writes: > branch: emacs-29 > commit 00de296d1b4f629fd828cdeff588bb4f742d9ffe > Author: F. Jason Park > Commit: Amin Bandali > > Simplify erc-sasl's auth-source API > > * doc/misc/erc.texi: Revise descriptions in SASL chapter to reflect > simplified auth-source options. > > * lisp/erc/erc-sasl.el (erc-sasl-password, > erc-sasl-auth-source-function): Revise doc strings. > (erc-sasl-auth-source-password-as-host): New function to serve as > more useful choice for option `erc-sasl-auth-source-function'. > (erc-sasl--read-password): Promote auth-source to pole position, above > an explicit string and `:password'. > > * test/lisp/erc/erc-sasl-tests.el (erc-sasl--read-password--basic): > Massage tests to conform to simplified `erc-sasl-password' > API. (Bug#29108.) Was such a big change really a regression fix, suitable for emacs-29?