From: Ihor Radchenko <yantar92@posteo.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 58558@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>, larsi@gnus.org
Subject: bug#58558: 29.0.50; re-search-forward is slow in some buffers
Date: Tue, 13 Dec 2022 18:40:17 +0000 [thread overview]
Message-ID: <875yef87vy.fsf@localhost> (raw)
In-Reply-To: <jwvtu1z9nxc.fsf-monnier+emacs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> The benchmark itself does not trigger the breakpoint.
>
> Does that mean that `Fmatch_data` is not called during a single
> `re-search-forward` (not a surprise: you'd need to put a breakpoint on
> `build_marker` to see the markers built by `buf_bytepos_to_charpos`)
> but is called between `re-search-forward`, or that it's not called at
> all during the whole benchmark where you perform several
> `re-search-forward` which grow progressively slower?
I do the benchmark via
M-:
(benchmark-progn (goto-char (point-min)) (while (re-search-forward yant/re nil t)))
<RET>
The breakpoint triggers after the minibuffer outputs the elapsed time.
During redisplay, AFAIU.
> If it's the latter, then those calls can't explain the slowdown, right?
The slowdown manifests by increasing elapsed time upon subsequent
benchmark calls like the above. So, redisplay may or may not be a part
of it.
I tried to run
(progn (benchmark-progn (goto-char (point-min)) (while (re-search-forward yant/re nil t))) (benchmark-progn (goto-char (point-min)) (while (re-search-forward yant/re nil t))))
4 times:
Elapsed time: 16.399824s
Elapsed time: 17.009694s
nil
Elapsed time: 18.187187s
Elapsed time: 18.597610s
nil
Elapsed time: 18.851388s
Elapsed time: 19.593968s
nil
Elapsed time: 20.194616s
Elapsed time: 20.414686s
nil
Though message may still trigger the redisplay. Not sure if this small
test really reveals anything useful.
Now, with (garbage-collect):
(progn (benchmark-progn (goto-char (point-min)) (while (re-search-forward yant/re nil t))) (garbage-collect) (benchmark-progn (goto-char (point-min)) (while (re-search-forward yant/re nil t))))
Elapsed time: 20.576637s
<GC>
Elapsed time: 15.734101s
Elapsed time: 16.101646s
<GC>
Elapsed time: 16.179796s
Elapsed time: 16.545040s
<GC>
Elapsed time: 16.365847s
Elapsed time: 16.842143s
<GC>
Elapsed time: 16.726615s
So, GC does help somewhat.
Then, if I kill and re-open the Org buffer:
Elapsed time: 72.847256s ;; <- Org just did a bunch of re-search for initial folding and setup
<GC>
Elapsed time: 4.864642s
re-open again, but GC before running the benchmark:
<GC>
Elapsed time: 4.884221s
<GC>
Elapsed time: 4.368755s
>> If I read the backtrace correctly, something in my custom mode-line is
>> triggering Fmatch_data that creates markers.
>
> The most common calls to `match-data` are from `save-match-data`.
> And most uses of `save-match-data` are ill-advised (as the docstring
> explains `save-match-data' should be used to save *your* match data
> rather than your caller's match data), so you might like to double check
> whether that call to `match-data` can be eliminated altogether.
This is coming from s.el. In any case, this implementation detail did
not change as I switched from Emacs 28 to Emacs 29. It is Emacs doing
something less efficiently here.
What I can try to do is replacing s-* functions in my mode-line with
built-ins. Will it help debugging this issue?
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-12-13 18:40 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 1:26 bug#58558: 29.0.50; re-search-forward is slow in some buffers Ihor Radchenko
2022-10-16 9:19 ` Lars Ingebrigtsen
2022-10-16 9:34 ` Ihor Radchenko
2022-10-16 9:37 ` Lars Ingebrigtsen
2022-10-16 10:02 ` Ihor Radchenko
2022-10-16 10:04 ` Lars Ingebrigtsen
2022-10-16 10:53 ` Ihor Radchenko
2022-10-16 11:01 ` Lars Ingebrigtsen
2022-10-16 11:21 ` Eli Zaretskii
2022-10-16 14:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-17 0:56 ` Ihor Radchenko
2022-10-18 11:50 ` Lars Ingebrigtsen
2022-10-18 14:58 ` Eli Zaretskii
2022-10-18 18:19 ` Lars Ingebrigtsen
2022-10-18 18:38 ` Eli Zaretskii
2022-12-13 10:28 ` Ihor Radchenko
2022-12-13 13:11 ` Eli Zaretskii
2022-12-13 13:32 ` Ihor Radchenko
2022-12-13 14:28 ` Eli Zaretskii
2022-12-13 15:56 ` Ihor Radchenko
2022-12-13 16:08 ` Eli Zaretskii
2022-12-13 17:43 ` Ihor Radchenko
2022-12-13 17:52 ` Eli Zaretskii
2022-12-13 18:03 ` Ihor Radchenko
2022-12-13 20:02 ` Eli Zaretskii
2022-12-14 11:40 ` Ihor Radchenko
2022-12-14 13:06 ` Eli Zaretskii
2022-12-14 13:23 ` Ihor Radchenko
2022-12-14 13:32 ` Eli Zaretskii
2022-12-14 13:39 ` Ihor Radchenko
2022-12-14 14:12 ` Eli Zaretskii
2022-12-13 18:15 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-13 18:40 ` Ihor Radchenko [this message]
2022-12-13 19:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-13 20:21 ` Eli Zaretskii
2022-12-14 11:42 ` Ihor Radchenko
2022-12-13 17:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-14 12:00 ` Ihor Radchenko
2022-12-14 12:23 ` Ihor Radchenko
2022-12-14 13:10 ` Eli Zaretskii
2022-12-14 13:26 ` Ihor Radchenko
2022-12-14 13:57 ` Eli Zaretskii
2022-12-14 14:01 ` Ihor Radchenko
2023-04-06 11:49 ` Ihor Radchenko
2023-04-06 12:05 ` Eli Zaretskii
2023-04-09 19:54 ` Ihor Radchenko
2023-04-10 4:14 ` Eli Zaretskii
2023-04-10 12:24 ` Ihor Radchenko
2023-04-10 13:40 ` Eli Zaretskii
2023-04-10 14:55 ` Ihor Radchenko
2023-04-10 16:04 ` Eli Zaretskii
2023-04-10 14:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-11 11:29 ` Ihor Radchenko
2023-04-11 11:51 ` Eli Zaretskii
2023-04-12 13:39 ` Ihor Radchenko
2023-04-12 14:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 14:30 ` Eli Zaretskii
2023-04-12 14:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 15:22 ` Eli Zaretskii
2023-04-12 15:59 ` Alan Mackenzie
2023-04-12 14:38 ` Stephen Berman
2023-04-12 14:42 ` Ihor Radchenko
2023-04-12 14:39 ` Ihor Radchenko
2023-04-12 15:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 23:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-13 4:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-13 20:05 ` Ihor Radchenko
2023-04-13 4:52 ` Eli Zaretskii
2023-04-13 5:15 ` Eli Zaretskii
2023-04-12 18:31 ` Alan Mackenzie
2023-04-12 23:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-13 4:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-13 12:09 ` Ihor Radchenko
2022-12-13 13:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-16 10:36 ` Eli Zaretskii
2023-02-19 12:17 ` Dmitry Gutov
2023-02-20 10:24 ` Ihor Radchenko
2023-02-20 14:54 ` Dmitry Gutov
2023-04-10 8:48 ` Mattias Engdegård
2023-04-10 9:57 ` Ihor Radchenko
2023-04-10 10:05 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yef87vy.fsf@localhost \
--to=yantar92@posteo.net \
--cc=58558@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.