From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Patch for reftex.el: master or release branch? Date: Wed, 14 Dec 2022 15:25:37 +0100 Message-ID: <875yeexdbe.fsf@gnu.org> References: <867cyuktnw.fsf@gnu.org> <83wn6um7x6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26490"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.9.6; emacs 30.0.50 Cc: Arash Esbati , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 14 16:08:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5TMV-0006gk-E5 for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Dec 2022 16:07:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5Srl-00079P-Mf; Wed, 14 Dec 2022 09:36:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Srk-000779-5c for emacs-devel@gnu.org; Wed, 14 Dec 2022 09:36:12 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Srj-0005jM-QZ for emacs-devel@gnu.org; Wed, 14 Dec 2022 09:36:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=UIaWNmjxOyPQbt7Ajw3+I/jZwy8eenwmD9R1/Vs9T3g=; b=VQM0Zr/6vTFXi1 86BmdenPixdf4A9X9lOlhKR4VyqOtRNZtww5dgppJB4dkawQlHdJMLYhxTFywqrNE2Ga0KJSLEnyF jD/BVmiPAP3cMasi7UaiChK6KgJ6jlBj7NSw/hlM9CN345bk8IIXolkfh6MrlbCozqgsSx/JVRQDC 4Z6IwRHxoyHcTeGYkjreR2uAbaCBHDZkkjYWhqa25k/LGEmrZDkp0jo8ZedGdxfCfPrE2i20XztrQ TH4BbdNXOi+cJk+eh1IQ9KscMcJdWo/l1oE9V54YJSWmmB/unE8s9XUzeiiW6o2swtFolY5K12CHI 4aUAgyHWSWi4NZnPKXFg==; Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5Srh-0003bu-CN; Wed, 14 Dec 2022 09:36:09 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id D848B27C0054; Wed, 14 Dec 2022 09:36:08 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 14 Dec 2022 09:36:08 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepud ejtdehuddvleffjeekteegvdehleehvdeufefhueekkeekhedvgfeggeffvefgnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Dec 2022 09:36:07 -0500 (EST) In-reply-to: <83wn6um7x6.fsf@gnu.org> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301392 Archived-At: Eli Zaretskii writes: Hi Eli & Arash, >> --8<---------------cut here---------------start------------->8--- >> diff --git a/lisp/textmodes/reftex.el b/lisp/textmodes/reftex.el >> index f815419ea4..126b3777f5 100644 >> --- a/lisp/textmodes/reftex.el >> +++ b/lisp/textmodes/reftex.el >> @@ -1004,10 +1004,13 @@ reftex-compile-variables >> reftex-section-levels)) >> >> ;; Calculate the regular expressions >> - (let* ( >> -; (wbol "\\(\\`\\|[\n\r]\\)[ \t]*") >> - (wbol "\\(^\\)%?[ \t]*") ; Need to keep the empty group because >> - ; match numbers are hard coded >> + (let* (;; (wbol "\\(\\`\\|[\n\r]\\)[ \t]*") >> + ;; Need to keep the empty group because match numbers are >> + ;; hard coded >> + (wbol (concat "\\(^\\)" >> + (when (string-suffix-p ".dtx" (buffer-file-name) t) >> + "%") >> + "[ \t]*")) >> (label-re (concat "\\(?:" >> (mapconcat #'identity reftex-label-regexps "\\|") >> "\\)")) >> --8<---------------cut here---------------end--------------->8--- >> >> Can you please tell me if this should go to master or emacs-29 >> branch? > > How safe is the change? If it is safe enough, emacs-29 is fine. > > Tassilo, WDYT about the safety of the patch and/or I would like to let Arash decide. I'm not familiar with that code but I guess he has tested his change and I trust him. The only thing the patch does is having a % in the regexp in the DTX case or omitting it in the "normal TeX" case instead of optionally allowing % in the latter case, too. That lead to the bug that commented sections also increased the section counter. > about the urgency to have the fix? Well, I guess it's broken since 2016 and only now a user complained. So the urgency is not very high. Bye, Tassilo