Re: [BUG] ob-sql sql-connection-alist

[Ihor Radchenko <yantar92@posteo.net>]

Daniel Kraus <daniel@kraus.my> writes:

>> I am looking at the docstring of `sql-connection-alist':
>>
>>     An alist of connection parameters for interacting with a SQL product.
>>      Each element of the alist is as follows:
>>
>>        (CONNECTION \(SQL-VARIABLE VALUE) ...)
>>
>>      Where CONNECTION is a case-insensitive string identifying the
>>      connection, ...
>>
>> So, your "setq" example is incorrect: must use "testdb" instead of
>> `testdb' symbol.
>
> I'm not sure why but I also have the connection as a symbol in my
> `sql-connection-alist`.
> Looking in `sql.el` `(sql-connect)`, they also use
> `assoc-string` to receive the connection:
> https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el?h=ac2a6fc83fac6390892b068a830ebe0f22364e05#n4398
>
> So I think that change is good and supports both formats
> (same as `sql-connect`).

Agree. In fact, I missed "insensitive" part of the docstring, reading it
opposite.

Andreas, feel free to send a proper patch with commit message. But
please do not decrease the copyright years :)

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>