Re: Merging feature/android

[Po Lu <luangruo@yahoo.com>]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Wed, 15 Mar 2023 18:25:43 +0800, Po Lu <luangruo@yahoo.com> said:
>
>     Po Lu> Oh, thanks!
>
> Weʼre not quite there yet :-)
>
> lisp/emacs-lisp/edebug-tests.log:
>
>   locate-file-internal(nil ("/home/rpluim/repos/emacs-android/lisp" "/
>   locate-file(nil ("/home/rpluim/repos/emacs-android/lisp" "/home/rplu
>   file-loadhist-lookup(nil)
>   file-provides(nil)
>   file-dependents(nil)
>   unload-feature(edebug-test-code)
>   #f(compiled-function () #<bytecode 0x5f78608ef6e90e6>)()
>   #f(compiled-function () #<bytecode 0x168e67691f944ca4>)()
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name edebug-tests-trivial-backquote :docum
>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>   ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
>   ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
>   ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
>   eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
>   command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/edebug-te
>   command-line()
>   normal-top-level()
> Test edebug-tests-trivial-backquote condition:
>     (wrong-type-argument stringp nil)
>
> which looks like an issue with load-history not containing an entry
> for the `edebug-test-code' feature? No idea yet for that
>
> And also:
>
> lisp/progmodes/eglot-tests.log:
>
> Test eglot-test-diagnostic-tags-unnecessary-code backtrace:
>   signal(ert-test-failed (((should (eq 'eglot-diagnostic-tag-unnecessa
>   ert-fail(((should (eq 'eglot-diagnostic-tag-unnecessary-face (face-a
>   #f(compiled-function () #<bytecode 0x11898351aa04629a>)()
>   eglot--call-with-fixture((("diag-project" ("main.cpp" . "int main(){
>   #f(compiled-function () #<bytecode -0x25d7fd8d71f4ef>)()
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name eglot-test-diagnostic-tags-unnecessar
>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>   ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
>   ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
>   ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
>   eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
>   command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/progmodes/eglot-test
>   command-line()
>   normal-top-level()
> Test eglot-test-diagnostic-tags-unnecessary-code condition:
>     (ert-test-failed
>      ((should
>        (eq 'eglot-diagnostic-tag-unnecessary-face
> 	    (face-at-point)))
>       :form
>       (eq eglot-diagnostic-tag-unnecessary-face flymake-warning)
>       :value nil))
>
> which I havenʼt investigated yet.
>
> Robert

I think I know why this is: I tried to fix a bug in the code which set
Vload_history when an undumped libemacs.so is run.

I'll look into this, thanks.