From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62573: 29.0.60; Cursor color not being inverted in emacs-29 Date: Sun, 02 Apr 2023 13:52:45 +0800 Message-ID: <875yaesudu.fsf@yahoo.com> References: <83edp420lx.fsf@gnu.org> <83bkk817rr.fsf@gnu.org> <83cz4myio7.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7497"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62573@debbugs.gnu.org, abdo.haji.ali@gmail.com, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 02 07:53:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piqeP-0001oO-F6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Apr 2023 07:53:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piqeG-0007Va-Sq; Sun, 02 Apr 2023 01:53:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piqeF-0007V6-9R for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 01:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piqeE-0005Ip-Ia for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 01:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1piqeE-0001ql-Dk for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 01:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Apr 2023 05:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62573 X-GNU-PR-Package: emacs Original-Received: via spool by 62573-submit@debbugs.gnu.org id=B62573.16804147817104 (code B ref 62573); Sun, 02 Apr 2023 05:53:02 +0000 Original-Received: (at 62573) by debbugs.gnu.org; 2 Apr 2023 05:53:01 +0000 Original-Received: from localhost ([127.0.0.1]:39005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piqeD-0001qW-67 for submit@debbugs.gnu.org; Sun, 02 Apr 2023 01:53:01 -0400 Original-Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:43989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piqeB-0001qJ-4b for 62573@debbugs.gnu.org; Sun, 02 Apr 2023 01:53:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1680414773; bh=0bhH9Z1B06Ix4RenNXcdlI4K/Fn5lH/o7ea6DWVliLY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=Pk4ppLtQajsjV8ryKpr+uvk5khifSg5B9gUHSJuaLkZgQRAq6XIY1RUktXXZbfvSFUfj8X1o1gMESgD1K1t+SF+/31/nE1AnGdhWTmAWJ/9BWqV1JwCAzjzzxmezUH/tEEtK8vGgxICFyOYIn3zeLCCyYeakUGjTXLatNkZpmuvgBn3q2RK2nQbsN6vQeTm7ZY0yfPD1ump+3o4hy41ALUd7hsL5oeh1QJ8V9RazxoyRn5cuOFMGmzymBCpOjUfsezGJFCaqZo0BmS2mUHAWcKQ0hqGWcqpqyDO8T9nWAFFG1lzIQNAgrfpu+MW7416PB9cTUw7HAxlpZMNfgbhrPg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1680414773; bh=pdpIIEIr/N5rqTdMcMmq/wUcWkslloH9iLXJm70aozq=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=sjZW8OPwNPnvd47KFtQIj3WzqTFPfQrgr/lu4zIzDmOAxIu+30QmIM+g3BqIjZtaNzlEHbstVHThBRv3gjHbbHsZ/8nAIuguQvjzbCE+bbCQQ3ohIMGfkgH242muruLB6VQJLxz5yHjMgxTxfe6CHqhqQu6XL0G+u+2C8EJDJP6dnN2MTkHMoh8zqHbEK1lolNxftSxH9y/V8qC/IHTY2LW5vAuO6NtlEFa10AgmzRcbXMOcF8aCn39qQ1HxgmZnTRQjl1hzrjoLidF36bWZGMAuJo5UqLqGKlB3NzlB/tK7wAW8JuGJQ18TMAWACaenZZ4mSGX20Y3Acpa8JMae2w== X-YMail-OSG: srK.jhsVM1lI7fLpAG989K1UU3CqIm7zs_r1VTezjCtyaitVAPHw.qkDNYjIFtV kMk8bTZV0bBq5.Saz2Eak9y.l5gGRMxmBmzm5dqsyhWcK2ZgiXaQdO5TOvSykg_3XC13lDMeclxp TJeq75AwdOJJpHyNTPhY1ijXDsXhbD0RbIV6E0mU6a71R4AImt10bgYDKJeM62L4SDxwHpifdzJv jz1bSVWRBMg66g5oARnM9BJ.27YWMJcUvE2QGTJCNMGCdwlMZz065LCsd6zYIteBD2B_o2ah.Vg. vnp.6kQISoavNbwtb1wNeJrT3RmDlfXQHNTP_9UFYUxIjLWhb2jpjpO4IZqW_ybiNecbscwhr1qv vLeJ_a1QKj_Rs76uoH0idNb4aNxbXqhzSutMo4hoKDS5HGyWP29ZG_JkPTDljy.f.v9E6Qn3bkJu WrQAM6VxtgMAzVUQvq0IqFboTDpe66sYXtQeI3GEFYBlQ7BSu2gXJqd3Q5irkGobZc0U0Zhf8gl_ 0ZLjTat0.79sry9PUbW7AwZXCIltFNIpG6tfSXObzlMnLMlW7SfqNtpnb45rOCCxb3L012xcpbL4 AC44MP2yJE5n_z9AzCjPesvN4c4L0yU_p3VISuITZbkDN83.Qdg1fA1O8FsRilA8JLJvEY7YC_96 4h.1i6_qtqfFZZxV0htGw1.IaMYx2PvlNv4CMIHSnHG2okNjtcKg0EiSSbTbaBYaJvwyE5GHOjPr 9pWQFy58hcsGzhBebGR7Hcq5WKU8dbQTdmGPz8_z2beIKPncAMfGP_pd3_VG5AKXIwixRjqtiBIp AUQDxXvv.VX9dLZPr6r6UiQEOvtpWBjMohkRP1Tbxn X-Sonic-MF: X-Sonic-ID: 98ff536c-c908-49b9-ab8d-29f0be8b10e9 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sun, 2 Apr 2023 05:52:53 +0000 Original-Received: by hermes--production-sg3-6d6fb994f6-q52kb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0764e3a48d44e4986157d5c8e496f684; Sun, 02 Apr 2023 05:52:50 +0000 (UTC) In-Reply-To: <83cz4myio7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 02 Apr 2023 08:09:12 +0300") X-Mailer: WebService/1.1.21284 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259092 Archived-At: Eli Zaretskii writes: >> From: Daniel Mart=C3=ADn >> Cc: Al Haji-Ali , 62573@debbugs.gnu.org, >> luangruo@yahoo.com >> Date: Sat, 01 Apr 2023 21:56:33 +0200 >>=20 >> This bug is a regression caused by >> 07715630ad9df9cb681cbadecbaf73fc9c698061. (Adding Po Lu to the CC.) >>=20 >> >From what I see, the font display refactor removed this code from >> src/nsterm.m: >>=20 >> - face =3D FACE_FROM_ID_OR_NULL (f, phys_cursor_glyph->face_id); >> - if (face && NS_FACE_BACKGROUND (face) >> - =3D=3D ns_index_color (FRAME_CURSOR_COLOR (f), f)) >> - { >> - [ns_lookup_indexed_color (NS_FACE_FOREGROUND (face), f) set]; >> - hollow_color =3D FRAME_CURSOR_COLOR (f); >> - } >> - else >>=20 >> which seems to be responsible for the cursor color change when the >> background face color is the same as the cursor color. I can't find >> that logic in the current code, so I think we miss it from the >> refactoring. >>=20 >> I've solved the bug by replicating that logic in the appropriate places, >> nsterm.m and macfont.m: > > This regression should be fixed on the release branch, but the patch > you propose is quite large. Can't we simply reinstate the removed > code, and apply the changes you propose only on master? Unfortunately not, as that would involve removing the ability to properly display mouse face with the Emacs 29 redisplay.