From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.help Subject: Re: Using called-interactively-p Date: Wed, 05 Jul 2023 19:52:33 +0200 Message-ID: <875y6yp7oe.fsf@dataswamp.org> References: <29YK7UN09CUBpmLBkjgZA21rkeTkTHa4vOBXFHEVZY-ehxjVNH0arkYgYEMNnng_ymDzv0bRr7O5u415Vgm4LT4cIbURmyxMXstXuiVPzo8=@proton.me> <87edlmjs81.fsf@mbork.pl> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25901"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:U2AQTQ6wWxO5c8Dw+ClcRisr4hE= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 11 14:21:52 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJCNL-0006VK-Gd for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 11 Jul 2023 14:21:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJCMn-0000fE-Mx; Tue, 11 Jul 2023 08:21:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH6gL-0007pC-3u for help-gnu-emacs@gnu.org; Wed, 05 Jul 2023 13:52:49 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH6gJ-0001lR-8s for help-gnu-emacs@gnu.org; Wed, 05 Jul 2023 13:52:48 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qH6gF-00091Z-GW for help-gnu-emacs@gnu.org; Wed, 05 Jul 2023 19:52:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 11 Jul 2023 08:20:50 -0400 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:144225 Archived-At: Marcin Borkowski wrote: >> The documentation suggests to use "called-interactively-p" >> instead of (interactive-p) [..] > > I would definitely bet on symbol. Using strings for things > like this seems highly unusual for me (in Elisp, as opposed > to e.g. JavaScript). > > OTOH, you can check if you want to (do-this) or (do-that) > using a simple trick with an optional parameter -- see > https://www.gnu.org/software/emacs/manual/html_node/elisp/Distinguish-Interactive.html It is better to not have functions do different things based on how it is called, that should only affect the interface. Please see yanked file: ;;; -*- lexical-binding: t -*- ;; ;; this file: ;; https://dataswamp.org/~incal/emacs-init/dwim.el ;; ;; DWIM code helpers and examples. ;; ;; Advantages to this style: ;; ;; - the same default interactively and from Lisp ;; - the default is the whole buffer ;; - the region is never used from Lisp ;; - the variables are always set, to the default if not explicitely ;; - one can still have preceding, non-optional arguments (defun use-region (&optional both) (if (use-region-p) (list (region-beginning) (region-end)) (when both (list nil nil) ))) (defun test-dwim (&optional beg end) (interactive (use-region)) (or beg (setq beg (point-min))) (or end (setq end (point-max))) (message "%d %d" beg end) ) (defun test-dwim-2 (re &optional beg end) (interactive `(,(read-regexp "regexp: ") ,@(use-region))) (or beg (setq beg (point-min))) (or end (setq end (point-max))) (message "%s %d %d" re beg end) ) (provide 'dwim) -- underground experts united https://dataswamp.org/~incal