From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Fri, 28 Jul 2023 06:33:56 +0300 Message-ID: <875y64wvyz.fsf@protesilaos.com> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9176"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64799@debbugs.gnu.org To: Dmitry Gutov , Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 28 05:42:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPEMd-0002BR-Jm for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jul 2023 05:42:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPEFt-0004vm-3O; Thu, 27 Jul 2023 23:35:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPEFr-0004vQ-1x for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 23:35:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPEFq-0004CJ-Nk for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 23:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qPEFq-0001bR-1t for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 23:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2023 03:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.16905152526101 (code B ref 64799); Fri, 28 Jul 2023 03:35:02 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 28 Jul 2023 03:34:12 +0000 Original-Received: from localhost ([127.0.0.1]:43393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPEF2-0001aL-BH for submit@debbugs.gnu.org; Thu, 27 Jul 2023 23:34:12 -0400 Original-Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:43917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPEEx-0001Zk-Ne for 64799@debbugs.gnu.org; Thu, 27 Jul 2023 23:34:11 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 1E6E460005; Fri, 28 Jul 2023 03:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1690515239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CHqnwMY57/WrT77ithKdS8f+SGn1oWPbg9bLBMfAx7k=; b=cI0EWjAUQJCvQOxdSQQCMizOAEXjPDnO9WGZTXqO3x1BinQ+8OBfbnCTlgG8Jqjk82Na1a jtgfJ9fqcceW+NhjTr2J4pcHmcf4/yrGxW01/yMK9VN3y4gfSpG9qSN5YTCI5S5MQGn77L uDQ6l9M2Qw8099Jt/eLB078OD0L0dWbIsxVgeOjm+41s4Gd3N6D72niIx+kvLAD5I36jT4 Hc6xdSuAciKXnfjraLYmAmlfcH4r8+UcyqbSFJ7cLXjveD9shN0BbFzTKrnt/fUwWtpEvo n00MZ1K81kL287WV1aSyKIuVxsemRJYOZwRu1E7bx68B7rY/DHrJsAJhYbEqfQ== In-Reply-To: <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> X-GND-Sasl: public@protesilaos.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266226 Archived-At: > From: Dmitry Gutov > Date: Thu, 27 Jul 2023 04:28:08 +0300 > [... 14 lines elided] > The change in format seems to go hand-in-hand with the change in face, > though, because help-key-binding has a box already. > > Does this look good to everybody? > > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index d482cc24d70..3611757fb82 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -1781,9 +1781,13 @@ project--keymap-prompt > (let ((key (if key > (vector key) > (where-is-internal cmd (list project-prefix-map) t)))) > - (format "[%s] %s" > - (propertize (key-description key) 'face 'bold) > - label))) > + (if (facep 'help-key-binding) > + (format "%s %s" > + (propertize (key-description key) 'face > 'help-key-binding) > + label) > + (format "[%s] %s" > + (propertize (key-description key) 'face 'bold) > + label)))) > project-switch-commands > " ")) I am fine with this approach, thank you! -- Protesilaos Stavrou https://protesilaos.com