[BUG] Cannot toggle the display of inline images [9.6.6 (release_9.6.6 @ /usr/local/share/emacs/29.1/lisp/org/)]

[BUG] Cannot toggle the display of inline images [9.6.6 (release_9.6.6 @ /usr/local/share/emacs/29.1/lisp/org/)]

[Eli Qian]

When updating to the new released Emacs 29.1, I found that 
org-mode cannot
toggle the display of inline images after reentering org-mode.

Steps to reproduce:
1. emacs -Q
2. M-x org-mode RET
3. Input a figure link, such as [[imge-path]]
4. M-x org-toggle-inline-images RET. You will see an image 
displayed in the
current buffer.
5. Keep the image display, type M-x org-mode RET
6. M-x org-toggle-inline-images RET, then you will find that the 
image cannot
be turned off.

It seems that org-mode generates more than one overlay for the 
image.
You can use `C-u C-x =` to verify it.

Emacs  : GNU Emacs 29.1 (build 2, x86_64-pc-linux-gnu, GTK+ 
Version 3.24.38, cairo version 1.17.8)
 of 2023-07-31
Package: Org mode version 9.6.6 (release_9.6.6 @ 
/usr/local/share/emacs/29.1/lisp/org/)

Re: [BUG] Cannot toggle the display of inline images [9.6.6 (release_9.6.6 @ /usr/local/share/emacs/29.1/lisp/org/)]

[Ihor Radchenko]

Eli Qian <eli.q.qian@gmail.com> writes:

> When updating to the new released Emacs 29.1, I found that 
> org-mode cannot
> toggle the display of inline images after reentering org-mode.
>
> Steps to reproduce:
> ...

Thanks for reporting and for providing the reproducer!
Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6c1ff952f

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>