From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: master 400df210ce0: Fix last change of 'delete-file'
Date: Thu, 10 Aug 2023 15:12:01 +0200 [thread overview]
Message-ID: <875y5n6nz2.fsf@gmail.com> (raw)
In-Reply-To: <20230806140407.09E6BC038BE@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Sun, 6 Aug 2023 10:04:06 -0400 (EDT)")
>>>>> On Sun, 6 Aug 2023 10:04:06 -0400 (EDT), Eli Zaretskii <eliz@gnu.org> said:
Eli> branch: master
Eli> commit 400df210ce0cc1ee0113b14a5ad92764d148c620
Eli> Author: Eli Zaretskii <eliz@gnu.org>
Eli> Commit: Eli Zaretskii <eliz@gnu.org>
Eli> Fix last change of 'delete-file'
Eli> * src/fileio.c (Fdelete_file_internal): Expand file name here, as
Eli> all primitives must.
Eli> (internal_delete_file): Adjust to the fact that Fdelete_file was
Eli> renamed.
Eli> * lisp/files.el (delete-file): Don't expand-file-name here, as
Eli> the called primitives already do. Fix typo in doc string.
I donʼt know if it matters, but along with esrʼs change this means we
now use the unexpanded file name for eg `find-file-name-handler', and
donʼt expand it until (if) we reach `internal_delete_file'.
Robert
--
next parent reply other threads:[~2023-08-10 13:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <169133064669.24990.11219399079845613336@vcs2.savannah.gnu.org>
[not found] ` <20230806140407.09E6BC038BE@vcs2.savannah.gnu.org>
2023-08-10 13:12 ` Robert Pluim [this message]
2023-08-10 13:25 ` master 400df210ce0: Fix last change of 'delete-file' Eli Zaretskii
2023-08-10 13:44 ` Robert Pluim
2023-08-10 13:57 ` Eli Zaretskii
2023-08-10 14:41 ` Robert Pluim
2023-08-10 15:00 ` Eli Zaretskii
2023-08-11 7:33 ` Michael Albinus
2023-08-11 10:59 ` Eli Zaretskii
2023-08-11 11:02 ` Eli Zaretskii
2023-08-11 11:41 ` Michael Albinus
2023-08-11 12:10 ` Eli Zaretskii
2023-08-11 17:24 ` Michael Albinus
2023-08-11 17:47 ` Eli Zaretskii
2023-08-12 9:57 ` Michael Albinus
2023-08-12 10:36 ` Eli Zaretskii
2023-08-12 11:03 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y5n6nz2.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.