From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Proposal to add Popper to ELPA Date: Sat, 09 Sep 2023 08:10:09 +0000 Message-ID: <875y4jdaxq.fsf@posteo.net> References: <874jk8ef0k.fsf@gmail.com> <87y1hkcygb.fsf@posteo.net> <255bb831-2309-764a-bb23-087ab267437b@gmail.com> <87wmx4cply.fsf@gmail.com> <87ledjcjhm.fsf@gmail.com> <87a5tw37c6.fsf@posteo.net> <87msxwib82.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35352"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mauro Aranda , emacs-devel@gnu.org To: Karthik Chikmagalur Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 09 10:11:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qet3g-000924-LI for ged-emacs-devel@m.gmane-mx.org; Sat, 09 Sep 2023 10:11:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qet2r-00052k-UW; Sat, 09 Sep 2023 04:10:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qet2n-0004zl-Ua for emacs-devel@gnu.org; Sat, 09 Sep 2023 04:10:17 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qet2j-00042T-Ti for emacs-devel@gnu.org; Sat, 09 Sep 2023 04:10:17 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 668B0240104 for ; Sat, 9 Sep 2023 10:10:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1694247010; bh=BGschwMexHgEPRA2t3gjOufs87LRsrkzzqWB9TmlWvY=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=W5s2uYqrBrSIkTS7fjTEJ97McDl6Ah61MMZCd4xvnhiq1g0awl+URUsptQExw6KaP o0YgjBdzTLFWOaB0u6VMo13FX0J4nlf+JZigRMHaxjsM07nsa/8X/GzlrVLbnISGHe bTrmc8T08ExlWkXTOMnEjnr0yLpMv3b9D2A+F07a8jwZ4Nd8J88YJHDLUpSyS97Zvw iL0j9N0FhnvXeeh6ed1OnTzwLn6c3geedB4QZ5nCXdxbkOi6MAsw7uKzrpoCj1Wk7H xYPwAHhV/PAgVzcz/iR1bIBwEb5Ng1Ou/IzsCbKCGS+SZN/vZNpiIOiPRf1oJx1MTi YGH6wYfiqAXwQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RjQdF6wCMz9rxG; Sat, 9 Sep 2023 10:10:09 +0200 (CEST) In-Reply-To: <87msxwib82.fsf@gmail.com> (Karthik Chikmagalur's message of "Fri, 08 Sep 2023 14:52:45 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310390 Archived-At: Karthik Chikmagalur writes: >> One more point, the user option `popper-echo-dispatch-keys' seems to >> have a broken type. Shouldn't it be something like >> >> (repeat (choice key-sequence character)) >> >> with proper tag annotations? > > I'm not sure it makes sense to enter these keybindings one-by-one, or to > have tags attached to each entry. The idea is that this is a list of > keys that will be bound to buffers. > > I will change it from (group string character) to (group key-sequence cha= racter). The issue here is that `group' is the wrong type. See (elisp) Composite Types, =E2=80=98(group ELEMENT-TYPES...)=E2=80=99 This works like =E2=80=98list=E2=80=99 except for the formatting of te= xt in the Custom buffer. and =E2=80=98(list ELEMENT-TYPES...)=E2=80=99 The value must be a list with exactly as many elements as the ELEMENT-TYPES given; and each element must fit the corresponding ELEMENT-TYPE. So your type now will match (list (kbd "C-a") ?z) but not (list (kbd "C-a")) (list ?z) (list) (list ?a ?z) (list (kbd "C-a") (kbd "C-a") ?z) or the current default value. > As an aside, how do I determine when a customization type was added to > Emacs? I want to be sure that (for instance) the `key-binding' type is > available on Emacs 26.1. I don't know if this is the best way, but I checked wid-edit.el and using vc-annotate I could see that it was added in 2005. It is also documented in the ChangeLog files. >> Other than that, I have added the package to the archive, thanks for >> contributing your package! > > Thank you Philip. > > Karthik